8252957: Wrong comment in CgroupV1Subsystem::cpu_quota

jerboaa · jerboaa · commit 5166094647f8 · 2020-09-09T13:53:10.000Z
The comment is wrong. The 'us' in 'cpu.cfs_quota_us' stands for
microseconds, which is read verbatim. Similarly for cgroups v2
all units in 'cpu.max' are in microseconds.

Reviewed-by: shade, hseigel
diff --git a/src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp b/src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp
@@ -203,11 +203,11 @@ char * CgroupV1Subsystem::cpu_cpuset_memory_nodes() {
 
 /* cpu_quota
  *
- * Return the number of milliseconds per period
+ * Return the number of microseconds per period
  * process is guaranteed to run.
  *
  * return:
- *    quota time in milliseconds
+ *    quota time in microseconds
  *    -1 for no quota
  *    OSCONTAINER_ERROR for not supported
  */
diff --git a/src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp b/src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp
@@ -74,11 +74,11 @@ int CgroupV2Subsystem::cpu_shares() {
 
 /* cpu_quota
  *
- * Return the number of milliseconds per period
+ * Return the number of microseconds per period
  * process is guaranteed to run.
  *
  * return:
- *    quota time in milliseconds
+ *    quota time in microseconds
  *    -1 for no quota
  *    OSCONTAINER_ERROR for not supported
  */

Original file line number	Diff line number	Diff line change
`@@ -203,11 +203,11 @@ char * CgroupV1Subsystem::cpu_cpuset_memory_nodes() {`
`203`	`203`
`204`	`204`	`/* cpu_quota`
`205`	`205`	`*`
`206`		`- * Return the number of milliseconds per period`
	`206`	`+ * Return the number of microseconds per period`
`207`	`207`	`* process is guaranteed to run.`
`208`	`208`	`*`
`209`	`209`	`* return:`
`210`		`- * quota time in milliseconds`
	`210`	`+ * quota time in microseconds`
`211`	`211`	`* -1 for no quota`
`212`	`212`	`* OSCONTAINER_ERROR for not supported`
`213`	`213`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -74,11 +74,11 @@ int CgroupV2Subsystem::cpu_shares() {`
`74`	`74`
`75`	`75`	`/* cpu_quota`
`76`	`76`	`*`
`77`		`- * Return the number of milliseconds per period`
	`77`	`+ * Return the number of microseconds per period`
`78`	`78`	`* process is guaranteed to run.`
`79`	`79`	`*`
`80`	`80`	`* return:`
`81`		`- * quota time in milliseconds`
	`81`	`+ * quota time in microseconds`
`82`	`82`	`* -1 for no quota`
`83`	`83`	`* OSCONTAINER_ERROR for not supported`
`84`	`84`	`*/`