Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge lworld #683

Conversation

vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Apr 12, 2022

Merge lworld


Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/683/head:pull/683
$ git checkout pull/683

Update a local copy of the PR:
$ git checkout pull/683
$ git pull https://git.openjdk.java.net/valhalla pull/683/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 683

View PR using the GUI difftool:
$ git pr show -t 683

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/683.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2022

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into universal-tvars will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@vicente-romero-oracle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 12, 2022

@vicente-romero-oracle Your integration request cannot be fulfilled at this time, as the status check jcheck did not complete successfully

@vicente-romero-oracle vicente-romero-oracle changed the title Merge branch 'lworld' into universal-tvars_merge_lworld_now Merge branch 'lworld' into universal-tvars Apr 12, 2022
@vicente-romero-oracle vicente-romero-oracle changed the title Merge branch 'lworld' into universal-tvars Merge lworld Apr 12, 2022
@openjdk
Copy link

openjdk bot commented Apr 12, 2022

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Merge lworld

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the universal-tvars branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the universal-tvars branch, type /integrate in a new comment.

@vicente-romero-oracle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 12, 2022

Going to push as commit 525b20d.

@openjdk openjdk bot added the integrated label Apr 12, 2022
@openjdk openjdk bot closed this Apr 12, 2022
@openjdk
Copy link

openjdk bot commented Apr 12, 2022

@vicente-romero-oracle Pushed as commit 525b20d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vicente-romero-oracle vicente-romero-oracle deleted the universal-tvars_merge_lworld_now branch August 10, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants