8273323: [lworld] Fix post-parse call devirtualization with inline type receiver

[TobiHartmann]

Post-parse call devirtualization (JDK-8257211) converts virtual calls to static calls which allows an inline type receiver to be passed as fields and the corresponding buffer allocation to become useless.

Currently, new inline type nodes created during that optimization and also such useless buffer allocations are not removed, leading to missed optimization opportunities and asserts. The problem is that call devirtualization is only executed after macro expansion which removes useless buffer allocations. I've moved the optimization to before macro expansion and added an assert to ensure that we are not missing any optimization opportunities.

I had to cherry-pick the mainline fix for JDK-8273409.

Best regards,
Tobias

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8273323: [lworld] Fix post-parse call devirtualization with inline type receiver

Reviewers

• Vladimir Ivanov (@iwanowww - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/549/head:pull/549
$ git checkout pull/549

Update a local copy of the PR:
$ git checkout pull/549
$ git pull https://git.openjdk.java.net/valhalla pull/549/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 549

View PR using the GUI difftool:
$ git pr show -t 549

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/549.diff

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273323: [lworld] Fix post-parse call devirtualization with inline type receiver

Reviewed-by: vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (dd156f96)

[iwanowww]

Looks good.

[TobiHartmann]

Thanks for the review, Vladimir!

[TobiHartmann]

/integrate

[openjdk]

Going to push as commit 252b04b.

[openjdk]

@TobiHartmann Pushed as commit 252b04b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.