-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8266324: [lworld] [lw3] Component type of arrays of primitive objects incorrectly loaded at link time #396
Conversation
👋 Welcome back fparain! A progress list of the required criteria for merging this PR into |
@fparain This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks, Harold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Lois
Thank you Lois and Harold! Fred |
/integrate |
@fparain Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 93c4160. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Small fix to prevent the VM from loading component types of arrays of primitive objects at link time.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/396/head:pull/396
$ git checkout pull/396
Update a local copy of the PR:
$ git checkout pull/396
$ git pull https://git.openjdk.java.net/valhalla pull/396/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 396
View PR using the GUI difftool:
$ git pr show -t 396
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/396.diff