Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251107: [lworld] test lworld-values/TopInterfaceNegativeTest.java is failing #139

Closed
wants to merge 1 commit into from
+6 −2
Closed

8251107: [lworld] test lworld-values/TopInterfaceNegativeTest.java is failing #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java
View file
Original file line number Diff line number Diff line change
@@ -1818,7 +1818,7 @@ public Boolean visitClassType(ClassType t, Type s) {
// Sidecast
if (s.hasTag(CLASS)) {
if ((s.tsym.flags() & INTERFACE) != 0) {
return ((t.tsym.flags() & FINAL) == 0)
return (dynamicTypeMayImplementAdditionalInterfaces(t.tsym))
? sideCast(t, s, warnStack.head)
: sideCastFinal(t, s, warnStack.head);
} else if ((t.tsym.flags() & INTERFACE) != 0) {
@@ -4616,7 +4616,7 @@ private boolean sideCastFinal(Type from, Type to, Warner warn) {
to = from;
from = target;
}
Assert.check((from.tsym.flags() & FINAL) != 0);
Assert.check(!dynamicTypeMayImplementAdditionalInterfaces(from.tsym));
Type t1 = asSuper(from, to.tsym);
if (t1 == null) return false;
Type t2 = to;
@@ -4628,6 +4628,10 @@ private boolean sideCastFinal(Type from, Type to, Warner warn) {
return true;
}

private boolean dynamicTypeMayImplementAdditionalInterfaces(TypeSymbol tsym) {
return (tsym.flags() & FINAL) == 0 && !tsym.isReferenceProjection();
}

private boolean giveWarning(Type from, Type to) {
List<Type> bounds = to.isCompound() ?
directSupertypes(to) : List.of(to);