Skip to content

Commit 6e580b3

Browse files
committedMar 27, 2020
8241748: Shenandoah: inline MarkingContext TAMS methods
Reviewed-by: rkennke
1 parent 92d854f commit 6e580b3

File tree

3 files changed

+34
-34
lines changed

3 files changed

+34
-34
lines changed
 

‎src/hotspot/share/gc/shenandoah/shenandoahMarkingContext.cpp

-30
Original file line numberDiff line numberDiff line change
@@ -59,36 +59,6 @@ void ShenandoahMarkingContext::initialize_top_at_mark_start(ShenandoahHeapRegion
5959
_top_bitmaps[idx] = bottom;
6060
}
6161

62-
void ShenandoahMarkingContext::capture_top_at_mark_start(ShenandoahHeapRegion *r) {
63-
size_t region_number = r->region_number();
64-
HeapWord* old_tams = _top_at_mark_starts_base[region_number];
65-
HeapWord* new_tams = r->top();
66-
67-
assert(new_tams >= old_tams,
68-
"Region " SIZE_FORMAT", TAMS updates should be monotonic: " PTR_FORMAT " -> " PTR_FORMAT,
69-
region_number, p2i(old_tams), p2i(new_tams));
70-
assert(is_bitmap_clear_range(old_tams, new_tams),
71-
"Region " SIZE_FORMAT ", bitmap should be clear while adjusting TAMS: " PTR_FORMAT " -> " PTR_FORMAT,
72-
region_number, p2i(old_tams), p2i(new_tams));
73-
74-
_top_at_mark_starts_base[region_number] = new_tams;
75-
_top_bitmaps[region_number] = new_tams;
76-
}
77-
78-
void ShenandoahMarkingContext::reset_top_at_mark_start(ShenandoahHeapRegion* r) {
79-
_top_at_mark_starts_base[r->region_number()] = r->bottom();
80-
}
81-
82-
HeapWord* ShenandoahMarkingContext::top_at_mark_start(ShenandoahHeapRegion* r) const {
83-
return _top_at_mark_starts_base[r->region_number()];
84-
}
85-
86-
void ShenandoahMarkingContext::reset_top_bitmap(ShenandoahHeapRegion* r) {
87-
assert(is_bitmap_clear_range(r->bottom(), r->end()),
88-
"Region " SIZE_FORMAT " should have no marks in bitmap", r->region_number());
89-
_top_bitmaps[r->region_number()] = r->bottom();
90-
}
91-
9262
void ShenandoahMarkingContext::clear_bitmap(ShenandoahHeapRegion* r) {
9363
HeapWord* bottom = r->bottom();
9464
HeapWord* top_bitmap = _top_bitmaps[r->region_number()];

‎src/hotspot/share/gc/shenandoah/shenandoahMarkingContext.hpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,12 @@ class ShenandoahMarkingContext : public CHeapObj<mtGC> {
6060

6161
inline MarkBitMap* mark_bit_map();
6262

63-
HeapWord* top_at_mark_start(ShenandoahHeapRegion* r) const;
64-
void capture_top_at_mark_start(ShenandoahHeapRegion* r);
65-
void reset_top_at_mark_start(ShenandoahHeapRegion* r);
63+
inline HeapWord* top_at_mark_start(ShenandoahHeapRegion* r) const;
64+
inline void capture_top_at_mark_start(ShenandoahHeapRegion* r);
65+
inline void reset_top_at_mark_start(ShenandoahHeapRegion* r);
6666
void initialize_top_at_mark_start(ShenandoahHeapRegion* r);
6767

68-
void reset_top_bitmap(ShenandoahHeapRegion *r);
68+
inline void reset_top_bitmap(ShenandoahHeapRegion *r);
6969
void clear_bitmap(ShenandoahHeapRegion *r);
7070

7171
bool is_bitmap_clear() const;

‎src/hotspot/share/gc/shenandoah/shenandoahMarkingContext.inline.hpp

+30
Original file line numberDiff line numberDiff line change
@@ -52,4 +52,34 @@ inline bool ShenandoahMarkingContext::allocated_after_mark_start(HeapWord* addr)
5252
return alloc_after_mark_start;
5353
}
5454

55+
inline void ShenandoahMarkingContext::capture_top_at_mark_start(ShenandoahHeapRegion *r) {
56+
size_t region_number = r->region_number();
57+
HeapWord* old_tams = _top_at_mark_starts_base[region_number];
58+
HeapWord* new_tams = r->top();
59+
60+
assert(new_tams >= old_tams,
61+
"Region " SIZE_FORMAT", TAMS updates should be monotonic: " PTR_FORMAT " -> " PTR_FORMAT,
62+
region_number, p2i(old_tams), p2i(new_tams));
63+
assert(is_bitmap_clear_range(old_tams, new_tams),
64+
"Region " SIZE_FORMAT ", bitmap should be clear while adjusting TAMS: " PTR_FORMAT " -> " PTR_FORMAT,
65+
region_number, p2i(old_tams), p2i(new_tams));
66+
67+
_top_at_mark_starts_base[region_number] = new_tams;
68+
_top_bitmaps[region_number] = new_tams;
69+
}
70+
71+
inline void ShenandoahMarkingContext::reset_top_at_mark_start(ShenandoahHeapRegion* r) {
72+
_top_at_mark_starts_base[r->region_number()] = r->bottom();
73+
}
74+
75+
inline HeapWord* ShenandoahMarkingContext::top_at_mark_start(ShenandoahHeapRegion* r) const {
76+
return _top_at_mark_starts_base[r->region_number()];
77+
}
78+
79+
inline void ShenandoahMarkingContext::reset_top_bitmap(ShenandoahHeapRegion* r) {
80+
assert(is_bitmap_clear_range(r->bottom(), r->end()),
81+
"Region " SIZE_FORMAT " should have no marks in bitmap", r->region_number());
82+
_top_bitmaps[r->region_number()] = r->bottom();
83+
}
84+
5585
#endif // SHARE_GC_SHENANDOAH_SHENANDOAHMARKINGCONTEXT_INLINE_HPP

0 commit comments

Comments
 (0)
Please sign in to comment.