Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

428: git-jcheck does not work on repositories without default or maser branch #676

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jun 24, 2020

Hi all,

please review this small patch that makes JCheck work on repositories without a remotee HEAD ref being present (i.e. refs/remotes/origin/HEAD) and without a master ref being present (i.e. refs/heads/master). In such a case JCheck will now fall back to configuration values for allowed tags and branches as specified in the configuration file at HEAD (HEAD is always present).

Testing:

  • make test passes on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/676/head:pull/676
$ git checkout pull/676

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jun 24, 2020
@edvbld edvbld changed the title skara-428 428 Jun 24, 2020
@edvbld edvbld changed the title 428 428: git-jcheck does not work on repositories without default or maser branch Jun 24, 2020
@mlbridge
Copy link

mlbridge bot commented Jun 24, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a spelling error in the title :)

@openjdk
Copy link

openjdk bot commented Jun 24, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

skara-428

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 7f84ac80545403c9677bd0505197659cf9bd4eb0.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 24, 2020
@edvbld edvbld changed the title 428: git-jcheck does not work on repositories without default or maser branch skara-428 Jun 24, 2020
@openjdk openjdk bot changed the title skara-428 428: git-jcheck does not work on repositories without default or maser branch Jun 24, 2020
@edvbld
Copy link
Member Author

edvbld commented Jun 24, 2020

/integrate

@openjdk openjdk bot closed this Jun 24, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 24, 2020
@openjdk
Copy link

openjdk bot commented Jun 24, 2020

@edvbld
Pushed as commit 645a73c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants