pr: do not fetch tags for backport command #1104
Closed
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
please review this patch that makes the
/backport
commit command not fetch tags. The/backport
command doesn't need the tags and different openjdk repositories can have slightly different hashes for the annotated tag object itself (not the commit the tag is referring to).I also updated the help text from the bot to instruct the user to fetch with
--no-tags
.Thanks,
Erik
Progress
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1104/head:pull/1104
$ git checkout pull/1104
Update a local copy of the PR:
$ git checkout pull/1104
$ git pull https://git.openjdk.java.net/skara pull/1104/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1104
View PR using the GUI difftool:
$ git pr show -t 1104
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1104.diff