Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewing help markdown does not work on gitlab #1096

Closed
wants to merge 1 commit into from
+7 −7
Closed

Reviewing help markdown does not work on gitlab #1096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
View file
Original file line number Diff line number Diff line change
@@ -530,30 +530,30 @@ private static String makeCollapsible(String summary, String content) {
private String reviewUsingGitHelp() {
var repoUrl = pr.repository().webUrl();
var firstTime =
"`$ git fetch " + repoUrl + " " + pr.fetchRef() + ":pull/" + pr.id() + "`\n" +
"`$ git fetch " + repoUrl + " " + pr.fetchRef() + ":pull/" + pr.id() + "` \\\n" +
"`$ git checkout pull/" + pr.id() + "`\n";
var updating =
"`$ git checkout pull/" + pr.id() + "`\n" +
"`$ git checkout pull/" + pr.id() + "` \\\n" +
"`$ git pull " + repoUrl + " " + pr.fetchRef() + "`\n";

return "Checkout this PR locally:\n" +
return "Checkout this PR locally: \\\n" +
firstTime +
"\n" +
"Update a local copy of the PR:\n" +
"Update a local copy of the PR: \\\n" +
updating;
}

private String reviewUsingSkaraHelp() {
return "Checkout this PR locally:\n" +
return "Checkout this PR locally: \\\n" +
("`$ git pr checkout " + pr.id() + "`\n") +
"\n" +
"View PR using the GUI difftool:\n" +
"View PR using the GUI difftool: \\\n" +
("`$ git pr show -t " + pr.id() + "`\n");
}

private String reviewUsingDiffsHelp() {
var diffUrl = pr.repository().webUrl() + "/pull/" + pr.id() + ".diff";
return "Download this PR as a diff file:\n" +
return "Download this PR as a diff file: \\\n" +
"<a href=\"" + diffUrl + "\">" + diffUrl + "</a>\n";
}