Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to stream region sampling data to a file #82

Closed
wants to merge 9 commits into from
+400 −25
Closed

Add an option to stream region sampling data to a file #82

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5aad4b1
Added logSnapshotsFile option in shenandoah_globals.hpp
chrisyoung-amzn Jun 22, 2021
079c603
Added Shenandoah logging flags and Shenandoah log file formatting
chrisyoung-amzn Jul 6, 2021
3f1bef5
Changed ShenandoahLogFileOutput to independent class and added copyri…
chrisyoung-amzn Jul 10, 2021
cd066f5
Fixed copyrights and added default value to ShenandoahRegionSamplingF…
chrisyoung-amzn Jul 19, 2021
a8b239d
Fixed Shenandoah log file path handling and file overwriting
chrisyoung-amzn Jul 30, 2021
613d797
Add a test that configured region sampling log file is created
earthling-amzn Oct 6, 2021
6cedcbc
Whitespace fixes
earthling-amzn Oct 7, 2021
f79314b
Update copyright headers
earthling-amzn Oct 7, 2021
e93d18d
Whitespace fixes
earthling-amzn Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/hotspot/share/gc/shenandoah/shenandoahHeapRegionCounters.cpp
View file
Original file line number Diff line number Diff line change
@@ -88,20 +88,16 @@ void ShenandoahHeapRegionCounters::update() {
if (ShenandoahRegionSampling) {
jlong current = nanos_to_millis(os::javaTimeNanos());
jlong last = _last_sample_millis;
if (current - last > ShenandoahRegionSamplingRate &&
Atomic::cmpxchg(&_last_sample_millis, last, current) == last) {
if (current - last > ShenandoahRegionSamplingRate && Atomic::cmpxchg(&_last_sample_millis, last, current) == last) {

ShenandoahHeap* heap = ShenandoahHeap::heap();

_status->set_value(encode_heap_status(heap));

_timestamp->set_value(os::elapsed_counter());

size_t num_regions = heap->num_regions();

{
ShenandoahHeapLocker locker(heap->lock());
size_t rs = ShenandoahHeapRegion::region_size_bytes();
size_t num_regions = heap->num_regions();
for (uint i = 0; i < num_regions; i++) {
ShenandoahHeapRegion* r = heap->get_region(i);
jlong data = 0;
1 change: 0 additions & 1 deletion src/hotspot/share/gc/shenandoah/shenandoahHeapRegionCounters.hpp
View file
Original file line number Diff line number Diff line change
@@ -101,4 +101,3 @@ class ShenandoahHeapRegionCounters : public CHeapObj<mtGC> {
};

#endif // SHARE_GC_SHENANDOAH_SHENANDOAHHEAPREGIONCOUNTERS_HPP

2 changes: 1 addition & 1 deletion src/hotspot/share/gc/shenandoah/shenandoahLogFileOutput.cpp
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
* Copyright (c) 2021, Amazon.com, Inc. All rights reserved.
* Copyright (c) 2015, 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
3 changes: 2 additions & 1 deletion src/hotspot/share/gc/shenandoah/shenandoahLogFileOutput.hpp
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/*
* Copyright (c) 2013, 2021, Red Hat, Inc. All rights reserved.
* Copyright (c) 2021, Amazon.com, Inc. All rights reserved.
* Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it