Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'generational' as value choice for JVM option 'ShenandoahGCMode'. #4

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

bernd-aws
Copy link
Contributor

@bernd-aws bernd-aws commented Oct 21, 2020

All upcoming GenShen code will be guarded by this JVM option. If generational mode is not set, Shenandoah will function in its original single-generational form, without changes or degradations.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/shenandoah pull/4/head:pull/4
$ git checkout pull/4

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2020

👋 Welcome back bmathiske! A progress list of the required criteria for merging this PR into genshen will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Copy link
Collaborator

@rkennke rkennke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should merge-in the master branch from openjdk/shenandoah, this should hopefully fix the jcheck complaints.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 27, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2020

Webrevs

@bernd-aws bernd-aws force-pushed the genshen1 branch 4 times, most recently from 82a2ef2 to 499a427 Compare October 27, 2020 10:46
Copy link
Collaborator

@rkennke rkennke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now! Thank you!

@openjdk
Copy link

openjdk bot commented Oct 27, 2020

@bernd-aws This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Add 'generational' as value choice for JVM option 'ShenandoahGCMode'.

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the genshen branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rkennke) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@rkennke rkennke merged commit 5077810 into openjdk:genshen Oct 27, 2020
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 27, 2020
@bernd-aws bernd-aws deleted the genshen1 branch November 16, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants