-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'generational' as value choice for JVM option 'ShenandoahGCMode'. #4
Conversation
👋 Welcome back bmathiske! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should merge-in the master branch from openjdk/shenandoah, this should hopefully fix the jcheck complaints.
src/hotspot/share/gc/shenandoah/mode/shenandoahGenerationalMode.cpp
Outdated
Show resolved
Hide resolved
src/hotspot/share/gc/shenandoah/mode/shenandoahGenerationalMode.cpp
Outdated
Show resolved
Hide resolved
src/hotspot/share/gc/shenandoah/mode/shenandoahGenerationalMode.hpp
Outdated
Show resolved
Hide resolved
Webrevs
|
82a2ef2
to
499a427
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now! Thank you!
@bernd-aws This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rkennke) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
All upcoming GenShen code will be guarded by this JVM option. If generational mode is not set, Shenandoah will function in its original single-generational form, without changes or degradations.
Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/shenandoah pull/4/head:pull/4
$ git checkout pull/4