Milestone 1 #13
Milestone 1 #13
Conversation
This is a placeholder for an internal commit that is being upstreamed. The
lines of code affected by the original internal commit were already changed
by some previously applied redundant commit operation. I'm leaving this
empty commit in place to facilitate audits of the source history.
As originally drafted, this commit removed lines 124 and 125 of
heuristics/shenandoahHeuristics.cpp:
// We never allocate humongous objects in young gen. (TODO: revisit this).
assert(region->affiliation() != ShenandoahRegionAffiliation::YOUNG_GENERATION, "Humongous object found in young gen.");
and added the following after line 315 in shenandoahFreeSet.cpp:
r->set_affiliation(req.affiliation());
|
👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Very nice! Only one question regarding what looks like a rogue include. Also, maybe the testprogram can be readily included as first jtreg test that exercises genshen when running make test TEST=hotspot_gc_shenandoah (even when it probably doesn't test anything except that it doesn't crash)?
| @@ -23,6 +23,7 @@ | |||
| */ | |||
|
|
|||
| #include "precompiled.hpp" | |||
| #include "gc/shenandoah/shenandoahHeap.inline.hpp" | |||
There was a problem hiding this comment.
What is this include used for?
There was a problem hiding this comment.
This include will be removed in the next commit.
Removed unneeded include in shenandoahCardTable.cpp. Established a new jtreg subdirectory for generational tests with accompanying changes to TEST.groups to exercise the new tests.
|
This looks good to me. I like the idea to include the test into hs_gc_shen as the first "real" jtreg test for genshen. In time, perhaps tier1 genshen tests (like "does card marking crash") should be in the Shenandoah tier1 tests, but for now I'm fine with it where you put it. |
|
@kdnilsen This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rkennke) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
/sponsor |
openjdk
bot
added
integrated
The objective of Milestone-1 is to demonstrate that certain heap regions can be designated as representing old-gen, card marking and remembered set implementation do not crash. Since the current implementation does not promote objects into old-gen space, much of the implementation of card marking and remembered set scanning is not exercised.
The following simple test program was used to demonstrate execution:
public class hello {
public static void main(String args[]) {
Node n = null;
for (int count = 10000; count > 0; count--) {
n = Node.upheaval(n);
System.out.print(count);
System.out.print(": Hello world: ");
for (int i = 0; i < args.length; i++) {
System.out.print(args[i]);
System.out.print(" ");
}
System.out.print("[node value is " + n.value() + "]");
System.out.println("");
}
}
}
import java.util.Random;
public class Node {
static private final int NeighborCount = 5;
static private Random random = new Random(46);
private int val;
private Object field_o;
private int[] field_ints;
private Node [] neighbors;
// Copy each neighbor of n into new node's neighbor array. Then overwrite
// arbitrarily selected neighbor with newly allocated leaf node.
public static Node upheaval(Node n) {
int first_val = random.nextInt();
if (first_val < 0) first_val = -first_val;
if (first_val < 0) first_val = 0;
Node result = new Node(first_val);
if (n != null) {
for (int i = 0; i < NeighborCount; i++)
result.neighbors[i] = n.neighbors[i];
}
int second_val = random.nextInt();
if (second_val < 0) second_val = -second_val;
if (second_val < 0) second_val = 0;
int overwrite_index = first_val % NeighborCount;
result.neighbors[overwrite_index] = new Node(second_val);
return result;
}
public Node(int val) {
this.val = val;
this.field_o = new Object();
this.field_ints = new int[8];
this.field_ints[0] = 0xca;
this.field_ints[1] = 0xfe;
this.field_ints[2] = 0xba;
this.field_ints[3] = 0xbe;
this.field_ints[4] = 0xba;
this.field_ints[5] = 0xad;
this.field_ints[6] = 0xba;
this.field_ints[7] = 0xbe;
this.neighbors = new Node[NeighborCount];
}
public int value() {
return val;
}
}
Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/shenandoah pull/13/head:pull/13$ git checkout pull/13