Skip to content

Commit 10ba541

Browse files
committedNov 20, 2020
8256727: ZGC: Clean out dead code after JDK-8212879
Reviewed-by: pliden
1 parent eb35ade commit 10ba541

9 files changed

+3
-68
lines changed
 

‎src/hotspot/share/gc/z/zBarrier.cpp

-19
Original file line numberDiff line numberDiff line change
@@ -198,25 +198,6 @@ uintptr_t ZBarrier::mark_barrier_on_finalizable_oop_slow_path(uintptr_t addr) {
198198
return mark<Follow, Finalizable, Overflow>(addr);
199199
}
200200

201-
uintptr_t ZBarrier::mark_barrier_on_root_oop_slow_path(uintptr_t addr) {
202-
assert(SafepointSynchronize::is_at_safepoint(), "Should be at safepoint");
203-
assert(during_mark(), "Invalid phase");
204-
205-
// Mark
206-
return mark<Follow, Strong, Publish>(addr);
207-
}
208-
209-
//
210-
// Relocate barrier
211-
//
212-
uintptr_t ZBarrier::relocate_barrier_on_root_oop_slow_path(uintptr_t addr) {
213-
assert(SafepointSynchronize::is_at_safepoint(), "Should be at safepoint");
214-
assert(during_relocate(), "Invalid phase");
215-
216-
// Relocate
217-
return relocate(addr);
218-
}
219-
220201
//
221202
// Narrow oop variants, never used.
222203
//

‎src/hotspot/share/gc/z/zBarrier.hpp

-7
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,6 @@ class ZBarrier : public AllStatic {
7373

7474
static uintptr_t mark_barrier_on_oop_slow_path(uintptr_t addr);
7575
static uintptr_t mark_barrier_on_finalizable_oop_slow_path(uintptr_t addr);
76-
static uintptr_t mark_barrier_on_root_oop_slow_path(uintptr_t addr);
77-
78-
static uintptr_t relocate_barrier_on_root_oop_slow_path(uintptr_t addr);
7976

8077
public:
8178
// Load barrier
@@ -112,12 +109,8 @@ class ZBarrier : public AllStatic {
112109
// Mark barrier
113110
static void mark_barrier_on_oop_field(volatile oop* p, bool finalizable);
114111
static void mark_barrier_on_oop_array(volatile oop* p, size_t length, bool finalizable);
115-
static void mark_barrier_on_root_oop_field(oop* p);
116112
static void mark_barrier_on_invisible_root_oop_field(oop* p);
117113

118-
// Relocate barrier
119-
static void relocate_barrier_on_root_oop_field(oop* p);
120-
121114
// Narrow oop variants, never used.
122115
static oop load_barrier_on_oop_field(volatile narrowOop* p);
123116
static oop load_barrier_on_oop_field_preloaded(volatile narrowOop* p, oop o);

‎src/hotspot/share/gc/z/zBarrier.inline.hpp

-13
Original file line numberDiff line numberDiff line change
@@ -407,17 +407,4 @@ inline void ZBarrier::mark_barrier_on_oop_array(volatile oop* p, size_t length,
407407
}
408408
}
409409

410-
inline void ZBarrier::mark_barrier_on_root_oop_field(oop* p) {
411-
const oop o = *p;
412-
root_barrier<is_good_or_null_fast_path, mark_barrier_on_root_oop_slow_path>(p, o);
413-
}
414-
415-
//
416-
// Relocate barrier
417-
//
418-
inline void ZBarrier::relocate_barrier_on_root_oop_field(oop* p) {
419-
const oop o = *p;
420-
root_barrier<is_good_or_null_fast_path, relocate_barrier_on_root_oop_slow_path>(p, o);
421-
}
422-
423410
#endif // SHARE_GC_Z_ZBARRIER_INLINE_HPP

‎src/hotspot/share/gc/z/zOopClosures.hpp

-6
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
#define SHARE_GC_Z_ZOOPCLOSURES_HPP
2626

2727
#include "memory/iterator.hpp"
28-
#include "gc/z/zRootsIterator.hpp"
2928

3029
class ZLoadBarrierOopClosure : public BasicOopIterateClosure {
3130
public:
@@ -53,11 +52,6 @@ class ZPhantomIsAliveObjectClosure : public BoolObjectClosure {
5352
virtual bool do_object_b(oop o);
5453
};
5554

56-
class ZPhantomKeepAliveOopClosure : public OopClosure {
57-
public:
58-
virtual void do_oop(oop* p);
59-
virtual void do_oop(narrowOop* p);
60-
};
6155
class ZPhantomCleanOopClosure : public OopClosure {
6256
public:
6357
virtual void do_oop(oop* p);

‎src/hotspot/share/gc/z/zOopClosures.inline.hpp

-8
Original file line numberDiff line numberDiff line change
@@ -76,14 +76,6 @@ inline bool ZPhantomIsAliveObjectClosure::do_object_b(oop o) {
7676
return ZBarrier::is_alive_barrier_on_phantom_oop(o);
7777
}
7878

79-
inline void ZPhantomKeepAliveOopClosure::do_oop(oop* p) {
80-
ZBarrier::keep_alive_barrier_on_phantom_oop_field(p);
81-
}
82-
83-
inline void ZPhantomKeepAliveOopClosure::do_oop(narrowOop* p) {
84-
ShouldNotReachHere();
85-
}
86-
8779
inline void ZPhantomCleanOopClosure::do_oop(oop* p) {
8880
// Read the oop once, to make sure the liveness check
8981
// and the later clearing uses the same value.

‎src/hotspot/share/gc/z/zRelocate.cpp

+1-14
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@
2525
#include "gc/z/zAddress.inline.hpp"
2626
#include "gc/z/zBarrier.inline.hpp"
2727
#include "gc/z/zForwarding.inline.hpp"
28-
#include "gc/z/zHeap.hpp"
29-
#include "gc/z/zOopClosures.inline.hpp"
28+
#include "gc/z/zHeap.inline.hpp"
3029
#include "gc/z/zPage.inline.hpp"
3130
#include "gc/z/zRelocate.hpp"
3231
#include "gc/z/zRelocationSet.inline.hpp"
@@ -39,22 +38,10 @@
3938
#include "prims/jvmtiTagMap.hpp"
4039

4140
static const ZStatCounter ZCounterRelocationContention("Contention", "Relocation Contention", ZStatUnitOpsPerSecond);
42-
static const ZStatSubPhase ZSubPhasePauseRootsJVMTITagMap("Pause Roots JVMTITagMap");
4341

4442
ZRelocate::ZRelocate(ZWorkers* workers) :
4543
_workers(workers) {}
4644

47-
class ZRelocateRootsIteratorClosure : public OopClosure {
48-
public:
49-
virtual void do_oop(oop* p) {
50-
ZBarrier::relocate_barrier_on_root_oop_field(p);
51-
}
52-
53-
virtual void do_oop(narrowOop* p) {
54-
ShouldNotReachHere();
55-
}
56-
};
57-
5845
uintptr_t ZRelocate::relocate_object_inner(ZForwarding* forwarding, uintptr_t from_index, uintptr_t from_offset) const {
5946
ZForwardingCursor cursor;
6047

‎src/hotspot/share/gc/z/zStackWatermark.hpp

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727
#include "gc/shared/barrierSet.hpp"
2828
#include "gc/shared/barrierSetNMethod.hpp"
29+
#include "gc/shared/threadLocalAllocBuffer.hpp"
2930
#include "gc/z/zOopClosures.hpp"
3031
#include "memory/allocation.hpp"
3132
#include "memory/iterator.hpp"

‎src/hotspot/share/gc/z/zWeakRootsProcessor.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
#include "precompiled.hpp"
2525
#include "gc/z/zOopClosures.inline.hpp"
26+
#include "gc/z/zRootsIterator.hpp"
2627
#include "gc/z/zTask.hpp"
2728
#include "gc/z/zWorkers.hpp"
2829

‎src/hotspot/share/gc/z/zWeakRootsProcessor.hpp

-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ class ZWeakRootsProcessor {
3333
public:
3434
ZWeakRootsProcessor(ZWorkers* workers);
3535

36-
void process_weak_roots();
3736
void process_concurrent_weak_roots();
3837
};
3938

0 commit comments

Comments
 (0)
Please sign in to comment.