-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8280845: riscv: Intrinsify BigInteger.montgomerySquare #56
Conversation
👋 Welcome back yzhu! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great numbers. Looks good.
@yhzhu20 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 20 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit bbc2132.
Your commit was automatically rebased without conflicts. |
Intrinsify BigInteger.montgomerySquare on RISCV.
On unmatched borad, performance of SPECjvm2008 crypto with intrinsic has improved 40%.
Hotspot/jdk tier1 passed on the unmatched board. And all jtreg tests have been tested on Qemu without new failures.
The details are as follows:
Tested with option “UseMontgomerySquareIntrinsic”.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/riscv-port pull/56/head:pull/56
$ git checkout pull/56
Update a local copy of the PR:
$ git checkout pull/56
$ git pull https://git.openjdk.java.net/riscv-port pull/56/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 56
View PR using the GUI difftool:
$ git pr show -t 56
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/riscv-port/pull/56.diff