8278277: G1: Simplify implementation of G1GCPhaseTimes::record_or_add_time_secs

Hamlin Li · Hamlin Li · commit 286a26c36600 · 2021-12-06T11:50:11.000Z
Reviewed-by: iwalulya, sjohanss, tschatzl
diff --git a/src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp b/src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp
@@ -266,11 +266,7 @@ void G1GCPhaseTimes::add_time_secs(GCParPhases phase, uint worker_id, double sec
 }
 
 void G1GCPhaseTimes::record_or_add_time_secs(GCParPhases phase, uint worker_id, double secs) {
-  if (_gc_par_phases[phase]->get(worker_id) == _gc_par_phases[phase]->uninitialized()) {
-    record_time_secs(phase, worker_id, secs);
-  } else {
-    add_time_secs(phase, worker_id, secs);
-  }
+  _gc_par_phases[phase]->set_or_add(worker_id, secs);
 }
 
 double G1GCPhaseTimes::get_time_secs(GCParPhases phase, uint worker_id) {

Original file line number	Diff line number	Diff line change
`@@ -266,11 +266,7 @@ void G1GCPhaseTimes::add_time_secs(GCParPhases phase, uint worker_id, double sec`
`266`	`266`	`}`
`267`	`267`
`268`	`268`	`void G1GCPhaseTimes::record_or_add_time_secs(GCParPhases phase, uint worker_id, double secs) {`
`269`		`- if (_gc_par_phases[phase]->get(worker_id) == _gc_par_phases[phase]->uninitialized()) {`
`270`		`- record_time_secs(phase, worker_id, secs);`
`271`		`- } else {`
`272`		`- add_time_secs(phase, worker_id, secs);`
`273`		`- }`
	`269`	`+ _gc_par_phases[phase]->set_or_add(worker_id, secs);`
`274`	`270`	`}`
`275`	`271`
`276`	`272`	`double G1GCPhaseTimes::get_time_secs(GCParPhases phase, uint worker_id) {`