Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263149: Adding some algorithms optimized by Vector API into JMH benc… #44

Closed

Conversation

sandlerwang
Copy link
Collaborator

@sandlerwang sandlerwang commented Mar 8, 2021

Here are some tests for Vector API JMH benchmarks.
These code came our work on optimizing Alibaba applications with Vector API.
VectorDistance contains Cosine distance and Euclidean Distance. The two distance algorithms are widely used in ElasticSearch, you can find opensource code here: github.com/opendistro-for-elasticsearch/k-NN/blob/aa5d1d40b136e2b3d33a14e80a2a374b2be015f9/src/main/java/com/amazon/opendistroforelasticsearch/knn/plugin/script/KNNScoringUtil.java#L61

BooleanArrayCheck and ValueRangeCheckAndCastL2I were developed during our optimization on OLAP systems.

Please help review this change.

Co-authored-by: Joshua Zhu jzhu@openjdk.org


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8263149

Issue

  • JDK-8263149: [VectorAPI]Adding benchmarks for Vector API ⚠️ Title mismatch between PR and JBS.

Download

$ git fetch https://git.openjdk.java.net/panama-vector pull/44/head:pull/44
$ git checkout pull/44

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 8, 2021

👋 Welcome back wzhuo! A progress list of the required criteria for merging this PR into vectorIntrinsics will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 8, 2021

⚠️ @sandlerwang a branch with the same name as the source branch for this pull request (vectorIntrinsics) is present in the target repository. If you eventually integrate this pull request then the branch vectorIntrinsics in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the vectorIntrinsics branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f vectorIntrinsics 97fef5c054d32edded3c54cddf8d7c23c64b0005
$ git push -f origin vectorIntrinsics

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk openjdk bot added the rfr label Mar 8, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 8, 2021

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

1 participant