Merge panama-vector:vector-unstable #4

nsjian · 2020-09-17T07:37:07Z

Merge

Progress

Change must not contain extraneous whitespace
Change must be properly reviewed

Reviewers

Paul Sandoz (@PaulSandoz - Committer) ⚠️ Review applies to bf3d59c

Download

$ git fetch https://git.openjdk.java.net/panama-vector pull/4/head:pull/4
$ git checkout pull/4

Co-authored-by: Joshua Zhu <joshua.zhu@arm.com> Co-authored-by: Yang Zhang <yang.zhang@arm.com> Reviewed-by: adinn, pli, ihse, vlivanov, eosterlund

…ption when supplied non strings Reviewed-by: lancea, naoto

Reviewed-by: jlaskey

…precated package Reviewed-by: vromero

Reviewed-by: aph, vlivanov, adinn

Reviewed-by: egahlin

Reviewed-by: rriggs

Reviewed-by: sgehwolf

…ler/optimizations tests Reviewed-by: thartmann

Reviewed-by: thartmann

Reviewed-by: erikj, jvernee, ehelin

…types Reviewed-by: lfoltan, psandoz

Updated CheckGraalIntrinsics.java test Reviewed-by: dcubed

…after JDK-8252354 Reviewed-by: alanb, joehw

Reviewed-by: dholmes, rehn

@Ignore-d

…er/HugeCapacity.java tests shouldn't be @Ignore-d Remove @ignore since @requires os.maxMemory is enough to ensure tests will not be executed if memory requirements are not satisfied Reviewed-by: coffeys

Cleanup code for jlink classes generation, move parsing file work to java.lang.invoke and add a new API in interface JavaLangInvokeAccess to generate holder classes, remove old APIs. The new API is used both by JLI and CDS. Reviewed-by: mchung, sundar

…ysdict Reviewed-by: dcubed, gziemski

Reviewed-by: darcy

Reviewed-by: dcubed, dholmes, pchilanomate, rehn, sspitsyn

Reviewed-by: mcimadamore

bridgekeeper · 2020-09-17T07:38:52Z

👋 Welcome back njian! A progress list of the required criteria for merging this PR into vectorIntrinsics will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

mlbridge · 2020-09-17T07:52:25Z

Webrevs

02: Full (e332482)
01: Full - Incremental (e91da6c)
00: Merge target (vectorIntrinsics) - Merge source (openjdk/panama-vector:vector-unstable) (bf3d59c)

nsjian · 2020-09-17T08:47:56Z

This is a clean merge, no conflicts.

PaulSandoz · 2020-09-17T14:39:46Z

@nsjian thank you for your understanding and working on vectorIntrinsics for now. Once we integrate the Vector API i hope we can follow up quickly.

nsjian · 2020-09-18T01:44:50Z

/integrate

openjdk · 2020-09-18T01:45:13Z

@nsjian Your merge request cannot be fulfilled at this time, as the status check jcheck did not complete successfully

nsjian · 2020-09-18T01:51:36Z

@PaulSandoz any idea how can I merge this? The jcheck always reports error. Either:

"Merge commit message is not Merge, but: Merge panama-vector:vector-unstable",

or

"Could not determine the source for this merge. A Merge PR title must be specified on the format: Merge project:branch to allow verification of the merge contents."

PaulSandoz · 2020-09-18T01:59:59Z

@nsjian I think there is an issue with the contents of the .jcheck/conf file. The [Merge] check message might need to be "message=Merge .*".

See this change made to the panama-foreign repo: openjdk/panama-foreign@64294f3#diff-916bf78a0828e8bef329c874c16980bf

I am checking with other engineers.

nsjian · 2020-09-18T02:04:34Z

See this change made to the panama-foreign repo: openjdk/panama-foreign@64294f3#diff-916bf78a0828e8bef329c874c16980bf

I am checking with other engineers.

Thanks!

nsjian · 2020-09-18T03:04:41Z

I have rebased my code, but the jcheck still failed.

nsjian · 2020-09-18T03:06:11Z

/integrate

openjdk · 2020-09-18T03:07:06Z

@nsjian Your merge request cannot be fulfilled at this time, as your changes failed the final jcheck:

Merge commit message is not Merge .*, but: Merge panama-vector:vector-unstable

Reviewed-by: psandoz

PaulSandoz · 2020-09-18T14:46:28Z

@nsjian I updated the .jcheck/conf file again as recommended (direct push rather than go through the pull request ceremony). Can you try again?

openjdk · 2020-09-18T14:47:14Z

@nsjian This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

Merge panama-vector:vector-unstable

Reviewed-by: psandoz

If you would like to add a summary, use the /summary command.
To credit additional contributors, use the /contributor command.
To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the vectorIntrinsics branch:

d6763b5: Update jconf

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge vectorIntrinsics into your branch, and then specify the current head hash when integrating, like this: /integrate d6763b5408ed7fa7ea035b20ab78758130972768.

➡️ To integrate this PR with the above commit message to the vectorIntrinsics branch, type /integrate in a new comment.

nsjian · 2020-09-19T09:39:44Z

/integrate

openjdk · 2020-09-19T09:40:32Z

@nsjian Since your change was applied there has been 1 commit pushed to the vectorIntrinsics branch:

d6763b5: Update jconf

Your commit was automatically rebased without conflicts.

Pushed as commit 925350f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

nsjian · 2020-09-19T09:43:42Z

@nsjian I updated the .jcheck/conf file again as recommended (direct push rather than go through the pull request ceremony). Can you try again?

@PaulSandoz Thanks! It works!

Ningsheng Jian and others added 23 commits September 2, 2020 09:45

8231441: AArch64: Initial SVE backend support

9b5a9b6

Co-authored-by: Joshua Zhu <joshua.zhu@arm.com> Co-authored-by: Yang Zhang <yang.zhang@arm.com> Reviewed-by: adinn, pli, ihse, vlivanov, eosterlund

8252354: Properties :: storeToXML method does not throw ClassCastExce…

38cd5d0

…ption when supplied non strings Reviewed-by: lancea, naoto

Added tag jdk-16+14 for changeset 36b29df125dc

869b051

8160601: unexpected error compiling @deprecated package

aab706c

Reviewed-by: jlaskey

8245664: javac erroneously issues deprecation warning for use of a de…

a951a15

…precated package Reviewed-by: vromero

8251525: AARCH64: Faster Math.signum(fp)

35ea000

Reviewed-by: aph, vlivanov, adinn

8252754: Hash code calculation of JfrStackTrace is inconsistent

43d3685

Reviewed-by: egahlin

8252538: Replace @exception with @throws java.rmi package

57a27a6

Reviewed-by: rriggs

8252359: HotSpot Not Identifying it is Running in a Container

76f0588

Reviewed-by: sgehwolf

8252720: clean up FileInstaller $test.src $cwd in vmTestbase/vm/compi…

850d623

…ler/optimizations tests Reviewed-by: thartmann

8251997: remove usage of PropertyResolvingWrapper in vmTestbase/vm/mlvm/

933f90f

Reviewed-by: thartmann

8241768: git needs .gitattributes

49a9d49

Reviewed-by: erikj, jvernee, ehelin

8244090: public lookup should find public members of public exported …

4e6a4af

…types Reviewed-by: lfoltan, psandoz

8252779: compiler/graalunit/HotspotTest.java failed after 8251525

a9e7859

Updated CheckGraalIntrinsics.java test Reviewed-by: dcubed

8252740: java/util/Properties/LoadAndStoreXMLWithDefaults.java fails …

ae5a6dd

…after JDK-8252354 Reviewed-by: alanb, joehw

8252521: possible race in java_suspend_self_with_safepoint_check

e25f2a5

Reviewed-by: dholmes, rehn

8249694: java/lang/StringBuffer/HugeCapacity.java and j/l/StringBuild…

0dadf81

…er/HugeCapacity.java tests shouldn't be @Ignore-d Remove @ignore since @requires os.maxMemory is enough to ensure tests will not be executed if memory requirements are not satisfied Reviewed-by: coffeys

8252004: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/s…

15af276

…ysdict Reviewed-by: dcubed, gziemski

8252307: javac rejects code with annotation applicable to fields

5d2e79e

Reviewed-by: darcy

8242427: JVMTI frame pop operations should use Thread-Local Handshakes

3e81b3a

Reviewed-by: dcubed, dholmes, pchilanomate, rehn, sspitsyn

8247352: improve error messages for sealed classes and records

4b3a0b7

Reviewed-by: mcimadamore

Manual merge with default

95cd392

nsjian changed the title ~~Merge with vector-unstable~~ Merge openjdk/panama-vector:vector-unstable Sep 17, 2020

openjdk bot added the rfr label Sep 17, 2020

PaulSandoz approved these changes Sep 17, 2020

View reviewed changes

nsjian force-pushed the merge-with-vector-unstable branch 2 times, most recently from 52559fb to e91da6c Compare September 18, 2020 01:38

nsjian changed the title ~~Merge panama-vector:vector-unstable~~ Merge Sep 18, 2020

openjdk bot removed the rfr label Sep 18, 2020

nsjian changed the title ~~Merge~~ Merge panama-vector:vector-unstable Sep 18, 2020

openjdk bot added the rfr label Sep 18, 2020

nsjian closed this Sep 18, 2020

nsjian reopened this Sep 18, 2020

Merge vector-unstable vectorIntrinsics

e332482

nsjian force-pushed the merge-with-vector-unstable branch from e91da6c to e332482 Compare September 18, 2020 03:01

openjdk bot added the ready label Sep 18, 2020

openjdk bot closed this Sep 19, 2020

openjdk bot added integrated and removed ready rfr labels Sep 19, 2020

nsjian deleted the merge-with-vector-unstable branch November 20, 2020 06:20

mlbridge bot mentioned this pull request Sep 3, 2021

Optimize mem barriers for ByteBuffer cases #104

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge panama-vector:vector-unstable #4

Merge panama-vector:vector-unstable #4

nsjian commented Sep 17, 2020 •

edited by openjdk bot

Loading

bridgekeeper bot commented Sep 17, 2020

mlbridge bot commented Sep 17, 2020 •

edited

Loading

nsjian commented Sep 17, 2020

PaulSandoz commented Sep 17, 2020

nsjian commented Sep 18, 2020

openjdk bot commented Sep 18, 2020

nsjian commented Sep 18, 2020

PaulSandoz commented Sep 18, 2020 •

edited

Loading

nsjian commented Sep 18, 2020

nsjian commented Sep 18, 2020

nsjian commented Sep 18, 2020

openjdk bot commented Sep 18, 2020

PaulSandoz commented Sep 18, 2020

openjdk bot commented Sep 18, 2020

nsjian commented Sep 19, 2020

openjdk bot commented Sep 19, 2020

nsjian commented Sep 19, 2020

Merge panama-vector:vector-unstable #4

Merge panama-vector:vector-unstable #4

Conversation

nsjian commented Sep 17, 2020 • edited by openjdk bot Loading

Progress

Reviewers

Download

bridgekeeper bot commented Sep 17, 2020

mlbridge bot commented Sep 17, 2020 • edited Loading

Webrevs

nsjian commented Sep 17, 2020

PaulSandoz commented Sep 17, 2020

nsjian commented Sep 18, 2020

openjdk bot commented Sep 18, 2020

nsjian commented Sep 18, 2020

PaulSandoz commented Sep 18, 2020 • edited Loading

nsjian commented Sep 18, 2020

nsjian commented Sep 18, 2020

nsjian commented Sep 18, 2020

openjdk bot commented Sep 18, 2020

PaulSandoz commented Sep 18, 2020

openjdk bot commented Sep 18, 2020

nsjian commented Sep 19, 2020

openjdk bot commented Sep 19, 2020

nsjian commented Sep 19, 2020

nsjian commented Sep 17, 2020 •

edited by openjdk bot

Loading

mlbridge bot commented Sep 17, 2020 •

edited

Loading

PaulSandoz commented Sep 18, 2020 •

edited

Loading