Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281147: Other tests that use the foreign API are missing --enable-preview #636

Closed

Conversation

FrauBoes
Copy link
Member

@FrauBoes FrauBoes commented Feb 2, 2022

This change adds the --enable-preview flag to tests in other areas (jdk.incubator.vector, java.util.stream) that use the (to be previewed) foreign API, as well as cleaning up the use of a no longer needed proxy class.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8281147: Other tests that use the foreign API are missing --enable-preview

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/636/head:pull/636
$ git checkout pull/636

Update a local copy of the PR:
$ git checkout pull/636
$ git pull https://git.openjdk.java.net/panama-foreign pull/636/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 636

View PR using the GUI difftool:
$ git pr show -t 636

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/636.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 2, 2022

👋 Welcome back jboes! A progress list of the required criteria for merging this PR into foreign-preview will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Feb 2, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 2, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 2, 2022

@FrauBoes This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281147: Other tests that use the foreign API are missing --enable-preview

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the foreign-preview branch:

  • 55a7e6c: 8278414: Replace binding recipe customization using MH combinators with bytecode spinning

Please see this link for an up-to-date comparison between the source branch of this pull request and the foreign-preview branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-preview branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Feb 2, 2022
@FrauBoes
Copy link
Member Author

FrauBoes commented Feb 3, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 3, 2022

Going to push as commit 24e45f6.
Since your change was applied there has been 1 commit pushed to the foreign-preview branch:

  • 55a7e6c: 8278414: Replace binding recipe customization using MH combinators with bytecode spinning

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 3, 2022
@openjdk openjdk bot closed this Feb 3, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Feb 3, 2022
@openjdk
Copy link

openjdk bot commented Feb 3, 2022

@FrauBoes Pushed as commit 24e45f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@FrauBoes FrauBoes deleted the preview-test-fixes branch February 3, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants