Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include for Linux #614

Closed

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Nov 18, 2021

This PR adds a missing include that is needed on Linux, which didn't show up when compiling under WSL.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/614/head:pull/614
$ git checkout pull/614

Update a local copy of the PR:
$ git checkout pull/614
$ git pull https://git.openjdk.java.net/panama-foreign pull/614/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 614

View PR using the GUI difftool:
$ git pr show -t 614

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/614.diff

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2021

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into foreign-memaccess+abi will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Nov 18, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2021

Webrevs

Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange - I did build and test the changes...

@openjdk
Copy link

openjdk bot commented Nov 18, 2021

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Add missing include for Linux

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the foreign-memaccess+abi branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-memaccess+abi branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Nov 18, 2021
@JornVernee
Copy link
Member Author

/integrate

@JornVernee
Copy link
Member Author

Strange - I did build and test the changes...

Okay, I think it might be dependent on the compiler version maybe then...

@openjdk
Copy link

openjdk bot commented Nov 18, 2021

Going to push as commit 68e9730.

@openjdk openjdk bot closed this Nov 18, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Nov 18, 2021
@openjdk
Copy link

openjdk bot commented Nov 18, 2021

@JornVernee Pushed as commit 68e9730.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JornVernee JornVernee deleted the Missing_Include branch November 26, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants