-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing include for Linux #614
Add missing include for Linux #614
Conversation
👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange - I did build and test the changes...
@JornVernee This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Okay, I think it might be dependent on the compiler version maybe then... |
Going to push as commit 68e9730. |
@JornVernee Pushed as commit 68e9730. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR adds a missing include that is needed on Linux, which didn't show up when compiling under WSL.
Progress
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/614/head:pull/614
$ git checkout pull/614
Update a local copy of the PR:
$ git checkout pull/614
$ git pull https://git.openjdk.java.net/panama-foreign pull/614/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 614
View PR using the GUI difftool:
$ git pr show -t 614
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/614.diff