8276136: functional interface extraction broken after API refresh

[mcimadamore]

This addresses the issue discovered in this thread:

https://mail.openjdk.java.net/pipermail/panama-dev/2021-September/015144.html

The issue is causes by the fact that the new linker changes introduce an asymmetry between the method type of the downcall and that of an upcall. Downcall have Addressable for parameters passed by-reference, and MemoryAddress for by-reference returns. Upcalls adopt the dual scheme (MemoryAddress for parameters, Addressable for return values).

This patch bridges the two schemes by inserting the required casts which keep invokeExact happy in the case where we generate a functional interface implementation which calls the upcall stub address.

To do that I had to dig a bit in TypeTranslator to make the type translation context-dependent. I also had to enhance FunctionInfo so that it could carry the "reverse" method type in the upcall case.

I've added a test which checks a function pointer which takes an address and returns another address - which stresses both argument and return mismatch.

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

• JDK-8276136: functional interface extraction broken after API refresh

Reviewers

• Jorn Vernee (@JornVernee - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/605/head:pull/605
$ git checkout pull/605

Update a local copy of the PR:
$ git checkout pull/605
$ git pull https://git.openjdk.java.net/panama-foreign pull/605/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 605

View PR using the GUI difftool:
$ git pr show -t 605

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/605.diff

[bridgekeeper]

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (ed64fa0e)

[JornVernee]

LGTM

[openjdk]

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276136: functional interface extraction broken after API refresh

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 122 new commits pushed to the foreign-jextract branch:

• 78c6658: 8275875: jextract branch fails to build due to javac serialization warning
• 0efd7f1: Automatic merge of foreign-memaccess+abi into foreign-jextract
• 0d35f42: Automatic merge of master into foreign-memaccess+abi
• 309df8a: Automatic merge of jdk:master into master
• 1efe946: 8275712: Hashtable literal_size functions are broken
• fab3d6c: 8275761: Backout: JDK-8274794 Print all owned locks in hs_err file
• c978ca8: 8275344: -Xcheck:jni produces some warnings in the LCMS.c
• 6a466fe: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields
• 4e9dd4b: 8275384: Change nested classes in jdk.jconsole to static nested classes
• 0961de4: 8275347: ciReplay: staticfield lines not properly terminated
• ... and 112 more: https://git.openjdk.java.net/panama-foreign/compare/d8f113c04de6d023101433b2a92f71cd5d70f974...foreign-jextract

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

[mcimadamore]

/integrate

[openjdk]

Going to push as commit ac0b4a1.
Since your change was applied there have been 207 commits pushed to the foreign-jextract branch:

• 2bfc3e4: 8276169: --with-libclang=no jextract module is still built and jextract tool is generated
• 8be2ddc: Automatic merge of foreign-memaccess+abi into foreign-jextract
• ed9bcef: Merge master
• 12cee54: Automatic merge of jdk:master into master
• 15fd8a3: 8276102: JDK-8245095 integration reverted JDK-8247980
• e89b2c0: 8276086: Increase size of metaspace mappings
• 24cf480: 8276047: G1: refactor G1CardSetArrayLocker
• e922023: 8275909: [JVMCI] c2v_readFieldValue use long instead of jlong for the offset parameter
• 157e1d5: 8275856: Remove MetaspaceHandleDeallocations debug switch
• c9e65f8: 8275440: Remove VirtualSpaceList::is_full()
• ... and 197 more: https://git.openjdk.java.net/panama-foreign/compare/d8f113c04de6d023101433b2a92f71cd5d70f974...foreign-jextract

Your commit was automatically rebased without conflicts.

[openjdk]

@mcimadamore Pushed as commit ac0b4a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.