8260583: jextract generates redundant constant files

[mcimadamore]

When testing performances of jextract generated code with big headers, I noticed that jextract was emitting empty constant files. After some debugging, I realized that the issues lies in the fact that ConstantHelper::build is called both by ToplevelBuilder::build and by HeaderFileBuilder::build - so, for every new header file split that is generated, we trigger a new constant file, even though that is not needed.

The solution is to remove the call from HeaderFileBuilder and just keep the one inside TopLevelBuilder.

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

• JDK-8260583: jextract generates redundant constant files

Reviewers

• Athijegannathan Sundararajan (@sundararajana - Committer)

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/440/head:pull/440
$ git checkout pull/440

[bridgekeeper]

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (fde3512)

[openjdk]

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260583: jextract generates redundant constant files

Reviewed-by: sundar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 233 new commits pushed to the foreign-jextract branch:

• 43f6a1c: 8260344: jextract crashes with exception for log.h from libdebian-installer4-dev
• 7df3a0e: Automatic merge of foreign-memaccess+abi into foreign-jextract
• aea0196: Automatic merge of master into foreign-memaccess+abi
• 5f05e37: Automatic merge of jdk:master into master
• d066f2b: 8260030: Improve stringStream buffer handling
• 1452280: 8164484: Unity, JTable cell editor, javax/swing/JComboBox/6559152/bug6559152.java
• a70acf2: 8259928: compiler/jvmci tests fail with -Xint
• ba38661: 8259882: Reduce the inclusion of perfData.hpp
• 92c2f08: 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
• a7c2ebc: 8239894: Xserver crashes when the wrong high refresh rate is used
• ... and 223 more: https://git.openjdk.java.net/panama-foreign/compare/88c025a4111fadb1b4f42f0cf09bfedb55dda35f...foreign-jextract

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

[mcimadamore]

/integrate

[openjdk]

@mcimadamore Since your change was applied there have been 233 commits pushed to the foreign-jextract branch:

• 43f6a1c: 8260344: jextract crashes with exception for log.h from libdebian-installer4-dev
• 7df3a0e: Automatic merge of foreign-memaccess+abi into foreign-jextract
• aea0196: Automatic merge of master into foreign-memaccess+abi
• 5f05e37: Automatic merge of jdk:master into master
• d066f2b: 8260030: Improve stringStream buffer handling
• 1452280: 8164484: Unity, JTable cell editor, javax/swing/JComboBox/6559152/bug6559152.java
• a70acf2: 8259928: compiler/jvmci tests fail with -Xint
• ba38661: 8259882: Reduce the inclusion of perfData.hpp
• 92c2f08: 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
• a7c2ebc: 8239894: Xserver crashes when the wrong high refresh rate is used
• ... and 223 more: https://git.openjdk.java.net/panama-foreign/compare/88c025a4111fadb1b4f42f0cf09bfedb55dda35f...foreign-jextract

Your commit was automatically rebased without conflicts.

Pushed as commit 1233eaf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.