Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252866: MemoryAccess.setAddress should take Addressable, not MemoryAddress (follow up) #315

Conversation

mcimadamore
Copy link
Collaborator

@mcimadamore mcimadamore commented Sep 9, 2020

This small patch fixes an oversight - MemoryAccess.setAddressAtOffset should call address() on the incoming value, before dispatching on the var handle.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8252866: MemoryAccess.setAddress should take Addressable, not MemoryAddress ⚠️ Title mismatch between PR and JBS.

Reviewers

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/315/head:pull/315
$ git checkout pull/315

Sorry, something went wrong.

@mcimadamore mcimadamore changed the title 8252866: MemoryAccess.setAddress should take Addressable, not MemoryAddress 8252866: MemoryAccess.setAddress should take Addressable, not MemoryAddress (follow up) Sep 9, 2020
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 9, 2020

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into foreign-memaccess will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mcimadamore
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 9, 2020

@mcimadamore This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252866: MemoryAccess.setAddress should take Addressable, not MemoryAddress (follow up)

Reviewed-by: sundar
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the foreign-memaccess branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 424c71b3d6f545a9245545cdd9fd50ce249a6e1e.

➡️ To integrate this PR with the above commit message to the foreign-memaccess branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Ready to be integrated rfr Ready for review labels Sep 9, 2020
@openjdk openjdk bot closed this Sep 9, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Sep 9, 2020
@openjdk
Copy link

openjdk bot commented Sep 9, 2020

@mcimadamore Pushed as commit bb4f95a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Sep 9, 2020

Webrevs

@mcimadamore mcimadamore deleted the memoryaccess+address_fix branch November 13, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants