8238316: jextract emits a C_BOOL when source says char #25
+107
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back sundar! A progress list of the required criteria for merging this PR into |
Webrevs
|
JornVernee
reviewed
Feb 21, 2020
src/jdk.incubator.jextract/share/classes/jdk/incubator/jextract/tool/JavaSourceBuilder.java
Outdated
Show resolved
Hide resolved
src/jdk.incubator.jextract/share/classes/jdk/incubator/jextract/tool/JavaSourceBuilder.java
Outdated
Show resolved
Hide resolved
src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/LayoutUtils.java
Outdated
Show resolved
Hide resolved
* adjusted test as suggested in the review. * support for "long double" for all platforms and expanded test.
sundararajana
force-pushed
the
JDK-8238316
branch
from
640bd26 to
ca463ab
Compare
|
@sundararajana This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
➡️ To integrate this PR with the above commit message, type |
mcimadamore
reviewed
Feb 24, 2020
| @@ -61,21 +61,24 @@ public static String getName(Cursor cursor) { | |||
|
|
|||
| public static MemoryLayout getLayout(Type t) { | |||
There was a problem hiding this comment.
What about COMPLEX_LONGDOUBLE and friends here?
|
/integrate |
openjdk
bot
added
integrated
|
@sundararajana |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using SystemABI.Type of MemoryLayouts to generate layout constants
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/panama-foreign pull/25/head:pull/25$ git checkout pull/25