Memory access implementation rewrite - post cleanup #110
+1,067
−305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be performance issues in the parallel test.
Add test which loops on slices
* rewrote paralel benchmark to use a non-recursive FJ action
…e various heap segment classes, as C2 wants sharp type information, as well as a null check. Todo: * fix support for mapped buffers (currently when creating a segment from a mapped segment is never created; also projecting a segment into a bytebuffer never creates the right mapped buffer) * cleanup code and doc
Added test
Renamed classes e.g. AbstractMemorySegment -> AbstractMemorySegmentImpl Fixed javadoc
Add benchmark for mapped segments Add more tests for buffer to segment conversions
Remove duplicate benchmark method
…ativeMemorySegmentImpl.java Co-Authored-By: Jorn Vernee <JornVernee@users.noreply.github.com>
…bstractMemorySegmentImpl.java Co-Authored-By: Jorn Vernee <JornVernee@users.noreply.github.com>
…eapMemorySegmentImpl.java Co-Authored-By: Jorn Vernee <JornVernee@users.noreply.github.com>
* Add check to ensure that Foreign::withSize and Foreign::asMallocSegment are called with unchecked address
|
👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into |
|
@mcimadamore this pull request can no longer be integrated into git checkout memaccess-impl-rewrite
git fetch https://git.openjdk.java.net/panama-foreign foreign-memaccess
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge foreign-memaccess"
git push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress
Download
$ git fetch https://git.openjdk.java.net/panama-foreign pull/110/head:pull/110$ git checkout pull/110