Skip to content

Commit a824289

Browse files
TheRealMDoerrTheRealMDoerr
committedOct 1, 2020
8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags
Reviewed-by: stuefe, lucy
1 parent 1d88172 commit a824289

File tree

1 file changed

+26
-25
lines changed

1 file changed

+26
-25
lines changed
 

‎src/hotspot/cpu/ppc/globals_ppc.hpp

+26-25
Original file line numberDiff line numberDiff line change
@@ -81,73 +81,74 @@ define_pd_global(intx, InitArrayShortSize, 9*BytesPerLong);
8181
range, \
8282
constraint) \
8383
\
84-
product(uintx, PowerArchitecturePPC64, 0, \
84+
product(uintx, PowerArchitecturePPC64, 0, DIAGNOSTIC, \
8585
"Specify the PowerPC family version in use. If not provided, " \
8686
"HotSpot will determine it automatically. Host family version " \
8787
"is the maximum value allowed (instructions are not emulated).") \
8888
\
89-
product(bool, SuperwordUseVSX, false, \
90-
"Use Power8 VSX instructions for superword optimization.") \
91-
\
9289
/* Reoptimize code-sequences of calls at runtime, e.g. replace an */ \
9390
/* indirect call by a direct call. */ \
94-
product(bool, ReoptimizeCallSequences, true, \
91+
product(bool, ReoptimizeCallSequences, true, DIAGNOSTIC, \
9592
"Reoptimize code-sequences of calls at runtime.") \
9693
\
9794
/* Power 8: Configure Data Stream Control Register. */ \
98-
product(uint64_t,DSCR_PPC64, (uintx)-1, \
95+
product(uint64_t, DSCR_PPC64, (uint64_t)-1, \
9996
"Power8 or later: Specify encoded value for Data Stream Control " \
10097
"Register") \
101-
product(uint64_t,DSCR_DPFD_PPC64, 8, \
98+
product(uint64_t, DSCR_DPFD_PPC64, 8, \
10299
"Power8 or later: DPFD (default prefetch depth) value of the " \
103100
"Data Stream Control Register." \
104101
" 0: hardware default, 1: none, 2-7: min-max, 8: don't touch") \
105-
product(uint64_t,DSCR_URG_PPC64, 8, \
102+
product(uint64_t, DSCR_URG_PPC64, 8, \
106103
"Power8 or later: URG (depth attainment urgency) value of the " \
107104
"Data Stream Control Register." \
108105
" 0: hardware default, 1: none, 2-7: min-max, 8: don't touch") \
109106
\
110-
product(bool, UseLoadInstructionsForStackBangingPPC64, false, \
107+
product(bool, UseLoadInstructionsForStackBangingPPC64, false, DIAGNOSTIC, \
111108
"Use load instructions for stack banging.") \
112109
\
110+
product(bool, UseStaticBranchPredictionInCompareAndSwapPPC64, true, DIAGNOSTIC,\
111+
"Use static branch prediction hints in CAS operations.") \
112+
product(bool, UseStaticBranchPredictionForUncommonPathsPPC64, false, DIAGNOSTIC,\
113+
"Use static branch prediction hints for uncommon paths.") \
114+
\
113115
/* special instructions */ \
114-
product(bool, UseByteReverseInstructions, false, \
116+
product(bool, SuperwordUseVSX, false, \
117+
"Use Power8 VSX instructions for superword optimization.") \
118+
\
119+
product(bool, UseByteReverseInstructions, false, DIAGNOSTIC, \
115120
"Use byte reverse instructions.") \
116121
\
117-
product(bool, UseVectorByteReverseInstructionsPPC64, false, \
122+
product(bool, UseVectorByteReverseInstructionsPPC64, false, DIAGNOSTIC, \
118123
"Use Power9 xxbr* vector byte reverse instructions.") \
119124
\
120-
product(bool, UseCountLeadingZerosInstructionsPPC64, true, \
125+
product(bool, UseCountLeadingZerosInstructionsPPC64, true, DIAGNOSTIC, \
121126
"Use count leading zeros instructions.") \
122127
\
123-
product(bool, UseCountTrailingZerosInstructionsPPC64, false, \
128+
product(bool, UseCountTrailingZerosInstructionsPPC64, false, DIAGNOSTIC, \
124129
"Use count trailing zeros instructions.") \
125130
\
126-
product(bool, UseExtendedLoadAndReserveInstructionsPPC64, false, \
131+
product(bool, UseExtendedLoadAndReserveInstructionsPPC64, false, DIAGNOSTIC,\
127132
"Use extended versions of load-and-reserve instructions.") \
128133
\
129-
product(bool, UseRotateAndMaskInstructionsPPC64, true, \
134+
product(bool, UseRotateAndMaskInstructionsPPC64, true, DIAGNOSTIC, \
130135
"Use rotate and mask instructions.") \
131136
\
132-
product(bool, UseStaticBranchPredictionInCompareAndSwapPPC64, true, \
133-
"Use static branch prediction hints in CAS operations.") \
134-
product(bool, UseStaticBranchPredictionForUncommonPathsPPC64, false, \
135-
"Use static branch prediction hints for uncommon paths.") \
136-
\
137137
/* Trap based checks. */ \
138138
/* Trap based checks use the ppc trap instructions to check certain */ \
139139
/* conditions. This instruction raises a SIGTRAP caught by the */ \
140140
/* exception handler of the VM. */ \
141141
product(bool, UseSIGTRAP, true, \
142142
"Allow trap instructions that make use of SIGTRAP. Use this to " \
143143
"switch off all optimizations requiring SIGTRAP.") \
144-
product(bool, TrapBasedICMissChecks, true, \
144+
product(bool, TrapBasedICMissChecks, true, DIAGNOSTIC, \
145145
"Raise and handle SIGTRAP if inline cache miss detected.") \
146-
product(bool, TraceTraps, false, "Trace all traps the signal handler" \
147-
"handles.") \
148146
\
149-
product(bool, ZapMemory, false, "Write 0x0101... to empty memory." \
150-
" Use this to ease debugging.") \
147+
product(bool, TraceTraps, false, DIAGNOSTIC, \
148+
"Trace all traps the signal handler handles.") \
149+
\
150+
develop(bool, ZapMemory, false, \
151+
"Write 0x0101... to empty memory. Use this to ease debugging.") \
151152
\
152153
/* Use Restricted Transactional Memory for lock elision */ \
153154
product(bool, UseRTMLocking, false, \

0 commit comments

Comments
 (0)
Please sign in to comment.