8280534: Enable compile-time doclint reference checking

Reviewed-by: serb, naoto, mchung, lancea, iris

Author: jddarcy

make/modules/java.base/Java.gmk

@@ -23,7 +23,7 @@
 # questions.
 #
 
-DOCLINT += -Xdoclint:all/protected,-reference \
+DOCLINT += -Xdoclint:all/protected \
     '-Xdoclint/package:java.*,javax.*'
 JAVAC_FLAGS += -XDstringConcat=inline
 COPY += .icu .dat .spp .nrm content-types.properties \

make/modules/java.datatransfer/Java.gmk

@@ -23,6 +23,6 @@
 # questions.
 #
 
-DOCLINT += -Xdoclint:all/protected,-reference \
+DOCLINT += -Xdoclint:all/protected \
     '-Xdoclint/package:java.*,javax.*'
 COPY += flavormap.properties

make/modules/java.logging/Java.gmk

@@ -23,5 +23,5 @@
 # questions.
 #
 
-DOCLINT += -Xdoclint:all/protected,-reference \
+DOCLINT += -Xdoclint:all/protected \
     '-Xdoclint/package:java.*,javax.*'

make/modules/java.management/Java.gmk

@@ -23,5 +23,5 @@
 # questions.
 #
 
-DOCLINT += -Xdoclint:all/protected,-reference \
+DOCLINT += -Xdoclint:all/protected \
     '-Xdoclint/package:java.*,javax.*'

src/java.base/share/classes/java/io/FilenameFilter.java

@@ -39,6 +39,7 @@
  * @see     java.io.File#list(java.io.FilenameFilter)
  * @since   1.0
  */
+@SuppressWarnings("doclint:reference") // cross-module links
 @FunctionalInterface
 public interface FilenameFilter {
     /**

src/java.base/share/classes/java/lang/Character.java

@@ -10305,6 +10305,7 @@ public static boolean isIdeographic(int codePoint) {
      * @see     java.compiler/javax.lang.model.SourceVersion#isIdentifier(CharSequence)
      * @since   1.1
      */
+    @SuppressWarnings("doclint:reference") // cross-module links
     public static boolean isJavaIdentifierStart(char ch) {
         return isJavaIdentifierStart((int)ch);
     }
@@ -10334,6 +10335,7 @@ public static boolean isJavaIdentifierStart(char ch) {
      * @see     java.compiler/javax.lang.model.SourceVersion#isIdentifier(CharSequence)
      * @since   1.5
      */
+    @SuppressWarnings("doclint:reference") // cross-module links
     public static boolean isJavaIdentifierStart(int codePoint) {
         return CharacterData.of(codePoint).isJavaIdentifierStart(codePoint);
     }
@@ -10371,6 +10373,7 @@ public static boolean isJavaIdentifierStart(int codePoint) {
      * @see     java.compiler/javax.lang.model.SourceVersion#isIdentifier(CharSequence)
      * @since   1.1
      */
+    @SuppressWarnings("doclint:reference") // cross-module links
     public static boolean isJavaIdentifierPart(char ch) {
         return isJavaIdentifierPart((int)ch);
     }
@@ -10404,6 +10407,7 @@ public static boolean isJavaIdentifierPart(char ch) {
      * @see     java.compiler/javax.lang.model.SourceVersion#isIdentifier(CharSequence)
      * @since   1.5
      */
+    @SuppressWarnings("doclint:reference") // cross-module links
     public static boolean isJavaIdentifierPart(int codePoint) {
         return CharacterData.of(codePoint).isJavaIdentifierPart(codePoint);
     }

src/java.base/share/classes/java/lang/System.java

@@ -1240,6 +1240,7 @@ public interface Logger {
          * @see java.lang.System.LoggerFinder
          * @see java.lang.System.Logger
          */
+        @SuppressWarnings("doclint:reference") // cross-module links
         public enum Level {
 
             // for convenience, we're reusing java.util.logging.Level int values
@@ -1600,6 +1601,7 @@ public void log(Level level, ResourceBundle bundle, String format,
      *
      * @since 9
      */
+    @SuppressWarnings("doclint:reference") // cross-module links
     public abstract static class LoggerFinder {
         /**
          * The {@code RuntimePermission("loggerFinder")} is

src/java.base/share/classes/java/lang/invoke/MethodHandleProxies.java

@@ -154,7 +154,8 @@ private MethodHandleProxies() { }  // do not instantiate
     // entry points, must be covered by hand-written or automatically
     // generated adapter classes.
     //
-    @SuppressWarnings("removal")
+    @SuppressWarnings({"removal",
+                       "doclint:reference"}) // cross-module links
     @CallerSensitive
     public static <T> T asInterfaceInstance(final Class<T> intfc, final MethodHandle target) {
         if (!intfc.isInterface() || !Modifier.isPublic(intfc.getModifiers()))

src/java.base/share/classes/java/lang/invoke/MethodHandles.java

@@ -2105,6 +2105,7 @@ static int optionsToFlag(Set<ClassOption> options) {
          * @jvms 5.5 Initialization
          * @jls 12.7 Unloading of Classes and Interfaces
          */
+        @SuppressWarnings("doclint:reference") // cross-module links
         public Lookup defineHiddenClass(byte[] bytes, boolean initialize, ClassOption... options)
                 throws IllegalAccessException
         {

src/java.base/share/classes/java/net/package-info.java

@@ -157,4 +157,5 @@
  *
  * @since 1.0
  */
+@SuppressWarnings("doclint:reference") // cross-module links
 package java.net;

src/java.base/share/classes/java/text/AttributedCharacterIterator.java

@@ -75,7 +75,7 @@
  * @see Annotation
  * @since 1.2
  */
-
+@SuppressWarnings("doclint:reference") // cross-module links
 public interface AttributedCharacterIterator extends CharacterIterator {
 
     /**

src/java.base/share/classes/java/text/Bidi.java

@@ -125,6 +125,7 @@ public Bidi(String paragraph, int flags) {
      * @see java.desktop/java.awt.font.TextAttribute#NUMERIC_SHAPING
      * @see java.desktop/java.awt.font.TextAttribute#RUN_DIRECTION
      */
+    @SuppressWarnings("doclint:reference") // cross-module links
     public Bidi(AttributedCharacterIterator paragraph) {
         if (paragraph == null) {
             throw new IllegalArgumentException("paragraph is null");

src/java.base/share/classes/java/util/Observable.java

@@ -73,6 +73,7 @@
  * {@link java.util.concurrent.Flow} API.
  */
 @Deprecated(since="9")
+@SuppressWarnings("doclint:reference") // cross-module links
 public class Observable {
     private boolean changed = false;
     private Vector<Observer> obs;

src/java.base/share/classes/java/util/ServiceLoader.java

@@ -1647,6 +1647,7 @@ static <S> ServiceLoader<S> load(Class<S> service,
      * @revised 9
      */
     @CallerSensitive
+    @SuppressWarnings("doclint:reference") // cross-module links
     public static <S> ServiceLoader<S> load(Class<S> service,
                                             ClassLoader loader)
     {

src/java.datatransfer/share/classes/java/awt/datatransfer/Clipboard.java

@@ -47,6 +47,7 @@
  * @see java.desktop/java.awt.Toolkit#getSystemSelection
  * @since 1.1
  */
+@SuppressWarnings("doclint:reference") // cross-module links
 public class Clipboard {
 
     String name;

src/java.logging/share/classes/java/util/logging/LogManager.java

@@ -2563,6 +2563,7 @@ private void setLevelsOnExistingLoggers() {
      *
      * @since 1.5
      */
+    @SuppressWarnings("doclint:reference")
     public static final String LOGGING_MXBEAN_NAME
         = "java.util.logging:type=Logging";
 
@@ -2581,6 +2582,7 @@ private void setLevelsOnExistingLoggers() {
      * @since 1.5
      */
     @Deprecated(since="9")
+    @SuppressWarnings("doclint:reference")
     public static synchronized LoggingMXBean getLoggingMXBean() {
         return Logging.getInstance();
     }

src/java.logging/share/classes/java/util/logging/LoggingMXBean.java

@@ -52,6 +52,7 @@
  * @see java.management/java.lang.management.PlatformLoggingMXBean
  */
 @Deprecated(since="9")
+@SuppressWarnings("doclint:reference")
 public interface LoggingMXBean {
 
     /**

src/java.management/share/classes/java/lang/management/ManagementFactory.java

@@ -246,7 +246,8 @@
  * @author  Mandy Chung
  * @since   1.5
  */
-@SuppressWarnings("removal")
+@SuppressWarnings({"removal",
+                   "doclint:reference"}) // cross-module links
 public class ManagementFactory {
     // A class with only static fields and methods.
     private ManagementFactory() {};

src/java.management/share/classes/java/lang/management/PlatformLoggingMXBean.java

@@ -46,6 +46,7 @@
  *
  * @since   1.7
  */
+@SuppressWarnings("doclint:reference") // cross-module links
 public interface PlatformLoggingMXBean extends PlatformManagedObject {
 
     /**

src/java.management/share/classes/javax/management/remote/JMXAddressable.java

@@ -41,6 +41,7 @@
  *
  * @since 1.6
  */
+@SuppressWarnings("doclint:reference") // cross-module links
 public interface JMXAddressable {
     /**
      * <p>The address of this object.</p>

src/java.management/share/classes/javax/management/remote/JMXServerErrorException.java

@@ -41,6 +41,7 @@
  * @see java.rmi/java.rmi.ServerError
  * @since 1.5
  */
+@SuppressWarnings("doclint:reference") // cross-module links
 public class JMXServerErrorException extends IOException {
 
     private static final long serialVersionUID = 3996732239558744666L;