8239878: Bug in PrintEliminateAllocations code causes TestClhsdbJstackLock.java to fail

Nils Eliasson · Nils Eliasson · commit 2ba0575ceabb · 2020-02-27T13:11:06.000+01:00
Reviewed-by: shade
diff --git a/src/hotspot/share/opto/macro.cpp b/src/hotspot/share/opto/macro.cpp
@@ -1629,11 +1629,12 @@ void PhaseMacroExpand::yank_alloc_node(AllocateNode* alloc) {
   }
 #ifndef PRODUCT
   if (PrintEliminateAllocations) {
-    if (alloc->is_AllocateArray()) {}
+    if (alloc->is_AllocateArray()) {
       tty->print_cr("++++ Eliminated: %d AllocateArray", alloc->_idx);
     } else {
       tty->print_cr("++++ Eliminated: %d Allocate", alloc->_idx);
     }
+  }
 #endif
   _igvn.remove_dead_node(alloc);
 }

Original file line number	Diff line number	Diff line change
`@@ -1629,11 +1629,12 @@ void PhaseMacroExpand::yank_alloc_node(AllocateNode* alloc) {`
`1629`	`1629`	`}`
`1630`	`1630`	`#ifndef PRODUCT`
`1631`	`1631`	`if (PrintEliminateAllocations) {`
`1632`		`- if (alloc->is_AllocateArray()) {}`
	`1632`	`+ if (alloc->is_AllocateArray()) {`
`1633`	`1633`	`tty->print_cr("++++ Eliminated: %d AllocateArray", alloc->_idx);`
`1634`	`1634`	`} else {`
`1635`	`1635`	`tty->print_cr("++++ Eliminated: %d Allocate", alloc->_idx);`
`1636`	`1636`	`}`
	`1637`	`+ }`
`1637`	`1638`	`#endif`
`1638`	`1639`	`_igvn.remove_dead_node(alloc);`
`1639`	`1640`	`}`