Skip to content

Commit 2173fed

Browse files
committedMar 18, 2021
8263439: getSupportedAttributeValues() throws NPE for Finishings attribute
Reviewed-by: psadhukhan, azvegint
1 parent e543a50 commit 2173fed

File tree

2 files changed

+67
-0
lines changed

2 files changed

+67
-0
lines changed
 

‎src/java.desktop/unix/classes/sun/print/IPPPrintService.java

+3
Original file line numberDiff line numberDiff line change
@@ -569,6 +569,9 @@ public DocPrintJob createPrintJob() {
569569
Finishings[] fAll = (Finishings[])
570570
(new ExtFinishing(100)).getAll();
571571
for (int j=0; j<fAll.length; j++) {
572+
if (fAll[j] == null) {
573+
continue;
574+
}
572575
if (finArray[i] == fAll[j].getValue()) {
573576
finSup[i] = fAll[j];
574577
break;
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
1+
/*
2+
* Copyright (c) 2002, 2021, Oracle and/or its affiliates. All rights reserved.
3+
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4+
*
5+
* This code is free software; you can redistribute it and/or modify it
6+
* under the terms of the GNU General Public License version 2 only, as
7+
* published by the Free Software Foundation.
8+
*
9+
* This code is distributed in the hope that it will be useful, but WITHOUT
10+
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11+
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12+
* version 2 for more details (a copy is included in the LICENSE file that
13+
* accompanied this code).
14+
*
15+
* You should have received a copy of the GNU General Public License version
16+
* 2 along with this work; if not, write to the Free Software Foundation,
17+
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18+
*
19+
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20+
* or visit www.oracle.com if you need additional information or have any
21+
* questions.
22+
*/
23+
24+
/*
25+
@test
26+
@key printer
27+
@bug 4722616 8263439
28+
@summary Verify no exception enumerating all attributes
29+
*/
30+
31+
import javax.print.PrintService;
32+
import javax.print.PrintServiceLookup;
33+
34+
public class PrintValues {
35+
36+
public static void main(String[] args) {
37+
38+
PrintService printer = PrintServiceLookup.lookupDefaultPrintService();
39+
if (printer == null) {
40+
System.out.println("No default printer configured. Cannot continue");
41+
return;
42+
}
43+
Class[] categories = printer.getSupportedAttributeCategories();
44+
45+
for (int i=0; i<categories.length; i++) {
46+
System.out.print("Class "+categories[i]);
47+
System.out.print(' ');
48+
Object value =
49+
printer.getSupportedAttributeValues (categories[i], null, null);
50+
if ((value != null) && (value.getClass().isArray())) {
51+
Object[] v = (Object[])value;
52+
for (int j=0; j<v.length; j++) {
53+
if (j > 0) {
54+
System.out.print(", ");
55+
}
56+
System.out.print(v[j]);
57+
}
58+
} else {
59+
System.out.print(value);
60+
}
61+
System.out.println();
62+
}
63+
}
64+
}

0 commit comments

Comments
 (0)
Please sign in to comment.