8249261: AssertionError in StructuralStuckChecker

Reviewed-by: mcimadamore

Author: lahodaj

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/DeferredAttr.java

@@ -918,6 +918,13 @@ public void visitApply(JCMethodInvocation tree) {
                 //do nothing
             }
 
+            @Override
+            public void visitConditional(JCTree.JCConditional tree) {
+                //skip tree.cond
+                scan(tree.truepart);
+                scan(tree.falsepart);
+            }
+
             @Override
             public void visitReference(JCMemberReference tree) {
                 Assert.checkNonNull(tree.getOverloadKind());

test/langtools/tools/javac/lambda/methodReference/MethodRefStuck8249261.java

@@ -0,0 +1,30 @@
+/*
+ * @test /nodynamiccopyright/
+ * @bug 8249261
+ * @summary Verify method references as conditions to conditional expressions
+ *          are handled properly.
+ * @compile/fail/ref=MethodRefStuck8249261.out -XDrawDiagnostics MethodRefStuck8249261.java
+ */
+class MethodRefStuck8249261 {
+
+    void p(int padding) {}
+
+    static boolean t() {
+        return true;
+    }
+
+    private void test() {
+        p(MethodRefStuck8249261::t);
+        p((MethodRefStuck8249261::t));
+        p(MethodRefStuck8249261::t + 1);
+        p(MethodRefStuck8249261::t ? 1 : 0);
+        p(true ? MethodRefStuck8249261::t : 0);
+        p(switch (MethodRefStuck8249261::t) { default -> 0; });
+        p(() -> true);
+        p((() -> true));
+        p((() -> true) + 1);
+        p((() -> true) ? 1 : 0);
+        p(true ? (() -> true) : 0);
+        p(switch ((() -> true)) { default -> 0; });
+  }
+}

test/langtools/tools/javac/lambda/methodReference/MethodRefStuck8249261.out

@@ -0,0 +1,13 @@
+MethodRefStuck8249261.java:17:9: compiler.err.cant.apply.symbol: kindname.method, p, int, @11, kindname.class, MethodRefStuck8249261, (compiler.misc.no.conforming.assignment.exists: (compiler.misc.not.a.functional.intf: int))
+MethodRefStuck8249261.java:18:9: compiler.err.cant.apply.symbol: kindname.method, p, int, @11, kindname.class, MethodRefStuck8249261, (compiler.misc.no.conforming.assignment.exists: (compiler.misc.not.a.functional.intf: int))
+MethodRefStuck8249261.java:19:11: compiler.err.unexpected.mref
+MethodRefStuck8249261.java:20:11: compiler.err.prob.found.req: (compiler.misc.not.a.functional.intf: boolean)
+MethodRefStuck8249261.java:21:9: compiler.err.cant.apply.symbol: kindname.method, p, int, @16, kindname.class, MethodRefStuck8249261, (compiler.misc.no.conforming.assignment.exists: (compiler.misc.incompatible.type.in.conditional: (compiler.misc.not.a.functional.intf: int)))
+MethodRefStuck8249261.java:22:19: compiler.err.unexpected.mref
+MethodRefStuck8249261.java:23:9: compiler.err.cant.apply.symbol: kindname.method, p, int, @11, kindname.class, MethodRefStuck8249261, (compiler.misc.no.conforming.assignment.exists: (compiler.misc.not.a.functional.intf: int))
+MethodRefStuck8249261.java:24:9: compiler.err.cant.apply.symbol: kindname.method, p, int, @11, kindname.class, MethodRefStuck8249261, (compiler.misc.no.conforming.assignment.exists: (compiler.misc.not.a.functional.intf: int))
+MethodRefStuck8249261.java:25:12: compiler.err.unexpected.lambda
+MethodRefStuck8249261.java:26:12: compiler.err.prob.found.req: (compiler.misc.not.a.functional.intf: boolean)
+MethodRefStuck8249261.java:27:9: compiler.err.cant.apply.symbol: kindname.method, p, int, @16, kindname.class, MethodRefStuck8249261, (compiler.misc.no.conforming.assignment.exists: (compiler.misc.incompatible.type.in.conditional: (compiler.misc.not.a.functional.intf: int)))
+MethodRefStuck8249261.java:28:20: compiler.err.unexpected.lambda
+12 errors