Skip to content

Commit 22bcd16

Browse files
author
Boris Ulasevich
committedNov 20, 2019
8233113: ARM32: assert on UnsafeJlong mutex rank check
Reviewed-by: coleenp, dholmes
1 parent 8534e92 commit 22bcd16

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed
 

‎src/hotspot/share/runtime/mutex.cpp

-2
Original file line numberDiff line numberDiff line change
@@ -288,8 +288,6 @@ Mutex::Mutex(int Rank, const char * name, bool allow_vm_block,
288288
assert(_safepoint_check_required != _safepoint_check_sometimes || is_sometimes_ok(name),
289289
"Lock has _safepoint_check_sometimes %s", name);
290290

291-
assert(_rank > special || _allow_vm_block,
292-
"Special locks or below should allow the vm to block");
293291
assert(_rank > special || _safepoint_check_required == _safepoint_check_never,
294292
"Special locks or below should never safepoint");
295293
#endif

‎test/hotspot/jtreg/runtime/Safepoint/NoSafepointVerifier.java

+2-6
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
/*
2525
* @test
2626
* @bug 8184732
27-
* @summary Ensure that special locks never safepoint check and are vm_block.
27+
* @summary Ensure that special locks never safepoint check.
2828
* @library /test/lib
2929
* @modules java.base/jdk.internal.misc
3030
* java.management
@@ -57,22 +57,18 @@ static void runTest(String test) throws Exception {
5757
}
5858

5959
static String test1 = "Special locks or below should never safepoint";
60-
static String test2 = "Special locks or below should allow the vm to block";
61-
static String test3 = "Possible safepoint reached by thread that does not allow it";
60+
static String test2 = "Possible safepoint reached by thread that does not allow it";
6261

6362
public static void main(String args[]) throws Exception {
6463
if (args.length > 0) {
6564
if (args[0].equals(test1)) {
6665
WhiteBox.getWhiteBox().assertSpecialLock(/*vm_block*/true, /*safepoint_check_always*/true);
6766
} else if (args[0].equals(test2)) {
68-
WhiteBox.getWhiteBox().assertSpecialLock(/*vm_block*/false, /*safepoint_check_always*/false);
69-
} else if (args[0].equals(test3)) {
7067
WhiteBox.getWhiteBox().assertSpecialLock(/*vm_block*/true, /*safepoint_check_always*/false);
7168
}
7269
} else {
7370
runTest(test1);
7471
runTest(test2);
75-
runTest(test3);
7672
}
7773
}
7874
}

0 commit comments

Comments
 (0)
Please sign in to comment.