Skip to content

Commit 0f1766d

Browse files
TheShermanTankermagicus
authored andcommittedMar 17, 2022
8283320: Error message for Windows libraries always points to --with-msvcr-dll no matter the actual file name
Reviewed-by: erikj, ihse
1 parent 69e4e33 commit 0f1766d

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed
 

‎make/autoconf/toolchain_microsoft.m4

+5-4
Original file line numberDiff line numberDiff line change
@@ -481,6 +481,7 @@ AC_DEFUN([TOOLCHAIN_CHECK_POSSIBLE_MSVC_DLL],
481481
AC_DEFUN([TOOLCHAIN_SETUP_MSVC_DLL],
482482
[
483483
DLL_NAME="$1"
484+
DLL_HELP="$2"
484485
MSVC_DLL=
485486
486487
if test "x$OPENJDK_TARGET_CPU" = xx86; then
@@ -565,7 +566,7 @@ AC_DEFUN([TOOLCHAIN_SETUP_MSVC_DLL],
565566
if test "x$MSVC_DLL" = x; then
566567
AC_MSG_CHECKING([for $DLL_NAME])
567568
AC_MSG_RESULT([no])
568-
AC_MSG_ERROR([Could not find $DLL_NAME. Please specify using --with-msvcr-dll.])
569+
AC_MSG_ERROR([Could not find $DLL_NAME. Please specify using ${DLL_HELP}.])
569570
fi
570571
])
571572

@@ -588,7 +589,7 @@ AC_DEFUN([TOOLCHAIN_SETUP_VS_RUNTIME_DLLS],
588589
fi
589590
MSVCR_DLL="$MSVC_DLL"
590591
else
591-
TOOLCHAIN_SETUP_MSVC_DLL([${MSVCR_NAME}])
592+
TOOLCHAIN_SETUP_MSVC_DLL([${MSVCR_NAME}], [--with-msvcr-dll])
592593
MSVCR_DLL="$MSVC_DLL"
593594
fi
594595
AC_SUBST(MSVCR_DLL)
@@ -611,7 +612,7 @@ AC_DEFUN([TOOLCHAIN_SETUP_VS_RUNTIME_DLLS],
611612
fi
612613
MSVCP_DLL="$MSVC_DLL"
613614
else
614-
TOOLCHAIN_SETUP_MSVC_DLL([${MSVCP_NAME}])
615+
TOOLCHAIN_SETUP_MSVC_DLL([${MSVCP_NAME}], [--with-msvcp-dll])
615616
MSVCP_DLL="$MSVC_DLL"
616617
fi
617618
AC_SUBST(MSVCP_DLL)
@@ -636,7 +637,7 @@ AC_DEFUN([TOOLCHAIN_SETUP_VS_RUNTIME_DLLS],
636637
fi
637638
VCRUNTIME_1_DLL="$MSVC_DLL"
638639
else
639-
TOOLCHAIN_SETUP_MSVC_DLL([${VCRUNTIME_1_NAME}])
640+
TOOLCHAIN_SETUP_MSVC_DLL([${VCRUNTIME_1_NAME}], [--with-vcruntime-1-dll])
640641
VCRUNTIME_1_DLL="$MSVC_DLL"
641642
fi
642643
fi

0 commit comments

Comments
 (0)
Please sign in to comment.