Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ShenandoahHeap::requires_barriers() #29

Closed
wants to merge 2 commits into from

Conversation

rkennke
Copy link
Contributor

@rkennke rkennke commented Feb 12, 2021

This add proper implementation of requires_barriers() for ShenandoahHeap, and adds some comments to CollectedHeap about it.

Testing (with a few other fixes in the pipeline):

  • java/lang/Continuation (-XX:+UseShenandoahGC -XX:ShenandoahGCMode=aggressive)
  • java/lang/Thread/virtual (-XX:+UseShenandoahGC -XX:ShenandoahGCMode=aggressive)

Progress

  • Change must not contain extraneous whitespace

Reviewers

Download

$ git fetch https://git.openjdk.java.net/loom pull/29/head:pull/29
$ git checkout pull/29

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 12, 2021

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into fibers will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 12, 2021

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Implement ShenandoahHeap::requires_barriers()

Reviewed-by: rpressler

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the fibers branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@pron) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Ready to be integrated rfr Ready for review labels Feb 12, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 12, 2021

Webrevs

@rkennke
Copy link
Contributor Author

rkennke commented Feb 12, 2021

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Feb 12, 2021
@openjdk
Copy link

openjdk bot commented Feb 12, 2021

@rkennke
Your change (at version 1095d76) is now ready to be sponsored by a Committer.

@pron
Copy link
Member

pron commented Feb 12, 2021

/sponsor

@openjdk openjdk bot closed this Feb 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Ready to sponsor ready Ready to be integrated rfr Ready for review labels Feb 12, 2021
@openjdk
Copy link

openjdk bot commented Feb 12, 2021

@pron @rkennke Pushed as commit 026a3eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants