Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help some ports build #185

Closed
wants to merge 5 commits into from
Closed

Help some ports build #185

wants to merge 5 commits into from

Conversation

pron
Copy link
Member

@pron pron commented May 6, 2022

Help some ports build.


Progress

  • Change must not contain extraneous whitespace

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/loom pull/185/head:pull/185
$ git checkout pull/185

Update a local copy of the PR:
$ git checkout pull/185
$ git pull https://git.openjdk.java.net/loom pull/185/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 185

View PR using the GUI difftool:
$ git pr show -t 185

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/loom/pull/185.diff

Sorry, something went wrong.

pron added 3 commits May 6, 2022 14:46
-

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@pron pron requested a review from coleenp May 6, 2022 15:04
@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2022

👋 Welcome back rpressler! A progress list of the required criteria for merging this PR into fibers will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 6, 2022

@pron This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Help some ports build

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the fibers branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the fibers branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Ready to be integrated rfr Ready for review labels May 6, 2022
@mlbridge
Copy link

mlbridge bot commented May 6, 2022

Webrevs

-

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
-

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@pron
Copy link
Member Author

pron commented May 6, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 6, 2022

Going to push as commit 6ce8cdc.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 6, 2022
@openjdk openjdk bot closed this May 6, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels May 6, 2022
@openjdk
Copy link

openjdk bot commented May 6, 2022

@pron Pushed as commit 6ce8cdc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pron pron deleted the args branch May 6, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants