Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alex Menkov review #149

Closed
wants to merge 6 commits into from
+11 −21
Closed

Alex Menkov review #149

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f3c0be0
Clean up wording for OPAQUE_FRAME error with ForceEarlyReturn
plummercj Apr 15, 2022
023e261
Get rid of unnecessary language for when both filters are added.
plummercj Apr 15, 2022
64d62d9
Fix freeing of memory in getAllThreads() when there is an error.
plummercj Apr 15, 2022
03be30f
Make trackVthreads final.
plummercj Apr 15, 2022
9475462
Fix some formatting.
plummercj Apr 15, 2022
1f30574
Minor spec rewording
plummercj Apr 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/java.se/share/data/jdwp/jdwp.spec
View file
Original file line number Diff line number Diff line change
@@ -2147,14 +2147,12 @@ JDWP "Java(tm) Debug Wire Protocol"
"the thread is not alive.")
(Error INVALID_OBJECT "Thread or value is not a known ID.")
(Error THREAD_NOT_SUSPENDED)
(Error OPAQUE_FRAME "Attempted to return early from "
"a frame corresponding to a native "
"method, "
(Error OPAQUE_FRAME "Attempted to return early from a frame "
"corresponding to a native method, "
"or the thread is a virtual thread and the target "
"VM is unable to force its current frame to return, "
"or the implementation is "
"unable to provide this functionality "
"on this frame.")
"or the implementation is unable to provide this "
"functionality on this frame.")
Copy link
Collaborator

@AlanBateman AlanBateman Apr 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection to joining the sentences but there is an extra "or" and a missing comma. I think this is how it should read in list form:

"Attempted to return early from a frame corresponding to a native method, the thread is a virtual thread and the target VM is unable to force its current frame to return, or the implementation is unable to provide this functionality on this frame."

(Error NO_MORE_FRAMES)
(Error NOT_IMPLEMENTED)
(Error TYPE_MISMATCH "Value is not an appropriate type for the "