-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower case verify calls #122
Conversation
👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into |
@coleenp This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
Thanks Robbin. |
Going to push as commit e684909.
Your commit was automatically rebased without conflicts. |
This is another cosmetic change to fix the verify functions so that there is one less null string assert.
This change also removes the copy_alignment template parameter as Patricio, Robbin and I noticed it's unused. Which is good because then we'd have to wonder when and why it would be less than the default. Also DWORD is a windows thing so looked odd in shared code and not sure if it matches what windows thinks DWORD is.
Progress
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/loom pull/122/head:pull/122
$ git checkout pull/122
Update a local copy of the PR:
$ git checkout pull/122
$ git pull https://git.openjdk.java.net/loom pull/122/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 122
View PR using the GUI difftool:
$ git pr show -t 122
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/loom/pull/122.diff