Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower case verify calls #122

Closed
wants to merge 2 commits into from
Closed

Lower case verify calls #122

wants to merge 2 commits into from

Conversation

coleenp
Copy link
Collaborator

@coleenp coleenp commented Mar 24, 2022

This is another cosmetic change to fix the verify functions so that there is one less null string assert.

This change also removes the copy_alignment template parameter as Patricio, Robbin and I noticed it's unused. Which is good because then we'd have to wonder when and why it would be less than the default. Also DWORD is a windows thing so looked odd in shared code and not sure if it matches what windows thinks DWORD is.


Progress

  • Change must not contain extraneous whitespace

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/loom pull/122/head:pull/122
$ git checkout pull/122

Update a local copy of the PR:
$ git checkout pull/122
$ git pull https://git.openjdk.java.net/loom pull/122/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 122

View PR using the GUI difftool:
$ git pr show -t 122

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/loom/pull/122.diff

Sorry, something went wrong.

@coleenp coleenp requested review from robehn and pron and removed request for robehn March 24, 2022 22:27
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 24, 2022

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into fibers will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 24, 2022

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Lower case verify calls

Reviewed-by: rehn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the fibers branch:

  • 90c37a5: JVMTI cleanup: get rid of unneeded debug tracing
  • 439b52b: Problem list tests that require at least 6 carrier threads, and therefore at least 6 cores. Only problem listed for macosx-x64.
  • b305b6e: split vthread problemlists

Please see this link for an up-to-date comparison between the source branch of this pull request and the fibers branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the fibers branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Ready to be integrated rfr Ready for review labels Mar 24, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 24, 2022

Webrevs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@coleenp
Copy link
Collaborator Author

coleenp commented Mar 25, 2022

Thanks Robbin.
/integrate

@openjdk
Copy link

openjdk bot commented Mar 25, 2022

Going to push as commit e684909.
Since your change was applied there have been 3 commits pushed to the fibers branch:

  • 90c37a5: JVMTI cleanup: get rid of unneeded debug tracing
  • 439b52b: Problem list tests that require at least 6 carrier threads, and therefore at least 6 cores. Only problem listed for macosx-x64.
  • b305b6e: split vthread problemlists

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 25, 2022
@openjdk openjdk bot closed this Mar 25, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Mar 25, 2022
@openjdk
Copy link

openjdk bot commented Mar 25, 2022

@coleenp Pushed as commit e684909.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the verify branch March 25, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants