Simplify G1CodeBlobClosure

[stefank]

There's no need to introduce a new _keepalive_is_strong property in the G1CodeBlobClosure. The existing _strong is set to true when the evacuation participates in the marking of the old gen, which is when we need to mark the nmethods as "maybe on continuation". The name _strong in this context is not great and it doesn't convey the actual meaning. Maybe something for a future G1 cleanup.

---

Progress

• Change must not contain extraneous whitespace

Reviewers

• Thomas Schatzl (@tschatzl - no project role)
• Erik Österlund (@fisk - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/loom pull/112/head:pull/112
$ git checkout pull/112

Update a local copy of the PR:
$ git checkout pull/112
$ git pull https://git.openjdk.java.net/loom pull/112/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 112

View PR using the GUI difftool:
$ git pr show -t 112

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/loom/pull/112.diff

[bridgekeeper]

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into fibers will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Simplify G1CodeBlobClosure

Reviewed-by: tschatzl, eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the fibers branch:

• 2aba64a: Fix SerialGC bug in full_process_roots
• da3d2da: JFR: adjustment
• 41d4ba5: JFR: cleanups
• 16e4713: Make compile on other platforms.
• 24a1e88: Fix problems with CompiledMethodIterator
• 3646ccf: Update com/sun/jdi test infra to allow for threads with no names
• c3398fa: Ensure isVirtual is cached
• 54f76b5: fix GetSetLocalTest for correct completion
• b9d53fd: Fix LoomVM flag

Please see this link for an up-to-date comparison between the source branch of this pull request and the fibers branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@fisk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (601b74fa)

[tschatzl]

Thanks for looking into this - that change has been one of the stranger to me as well.

Looks good.

[stefank]

Thanks for reviewing!
/integrate defer

[openjdk]

@stefank Integration of this pull request has been deferred and may be completed by any project committer using the /integrate pull request command.

[fisk]

/integrate

[openjdk]

@fisk
Your change (at version 601b74f) is now ready to be sponsored by a Committer.

[fisk]

/sponsor

[openjdk]

Going to push as commit 61d79b2.
Since your change was applied there have been 20 commits pushed to the fibers branch:

• c4b9561: JFR: subtle time function pointer address change in refactoring
• 96e5a7c: Move back BacktraceBuilder
• 0a95b70: JFR: hosting type Thread does not map to < 127, because all events are mapped before types
• 862a0b2: JFR: adjustment
• 87a93c2: JFR: adjustment
• 857eb99: use is_special_native_intrinsic() in Method::is_always_compilable()
• 5c7fbbf: Test for can_be_deoptimized() in CodeCache::make_marked_nmethods_deoptimized
• 42ad345: Initialize ConstantPoolCache::_marking_cycle
• a3af3cd: -
• 18ab1a6: Small fixes - shipment one
• ... and 10 more: https://git.openjdk.java.net/loom/compare/430623484ec8470458499cb645e752e34b04a8b8...fibers

Your commit was automatically rebased without conflicts.

[openjdk]

@fisk @stefank Pushed as commit 61d79b2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.