Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note frames that are on the heap, rather than addressing mode #106

Closed
wants to merge 3 commits into from

Conversation

coleenp
Copy link
Collaborator

@coleenp coleenp commented Mar 16, 2022

... for interpreted frames.
This changes "addressing mode" to a boolean whether the frame is on the heap instead. The compiler frames don't have code that uses the relative offsets but the frames can be marked as on-heap anyway.
There's one place that I passed false, not sure if that's right.
Not urgent to code review.
Tested with: alias loomjprt='mach5 --patch-based --extra-src-dirs /scratch/cphillim/hg/jdk-loom -j loom-tier1,loom-tier2,loom-tier3'


Progress

  • Change must not contain extraneous whitespace

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/loom pull/106/head:pull/106
$ git checkout pull/106

Update a local copy of the PR:
$ git checkout pull/106
$ git pull https://git.openjdk.java.net/loom pull/106/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 106

View PR using the GUI difftool:
$ git pr show -t 106

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/loom/pull/106.diff

Sorry, something went wrong.

coleenp added 2 commits March 15, 2022 15:47

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…erpreted frames.
@coleenp coleenp requested a review from pron March 16, 2022 14:27
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 16, 2022

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into fibers will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 16, 2022

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Note frames that are on the heap, rather than addressing mode

Reviewed-by: rpressler

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the fibers branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the fibers branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Ready to be integrated rfr Ready for review labels Mar 16, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 16, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 16, 2022

@coleenp this pull request can not be integrated into fibers due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout heap-frame
git fetch https://git.openjdk.java.net/loom fibers
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge fibers"
git push

@openjdk openjdk bot added merge-conflict and removed ready Ready to be integrated labels Mar 16, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@coleenp
Copy link
Collaborator Author

coleenp commented Mar 17, 2022

Thanks Ron!
/integrate

@openjdk openjdk bot added ready Ready to be integrated and removed merge-conflict labels Mar 17, 2022
@openjdk
Copy link

openjdk bot commented Mar 17, 2022

Going to push as commit d405b73.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 17, 2022
@openjdk openjdk bot closed this Mar 17, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Mar 17, 2022
@coleenp coleenp deleted the heap-frame branch March 17, 2022 18:39
@openjdk
Copy link

openjdk bot commented Mar 17, 2022

@coleenp Pushed as commit d405b73.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants