Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix includes, braces, and whitespaces #103

Closed

Conversation

stefank
Copy link
Member

@stefank stefank commented Mar 16, 2022

Fix includes

  • sort order
  • missing includes
  • .inline.hpp from .hpp file

Add braces to if/for statements

Fix whitespaces, newlines and alignment


Progress

  • Change must not contain extraneous whitespace

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/loom pull/103/head:pull/103
$ git checkout pull/103

Update a local copy of the PR:
$ git checkout pull/103
$ git pull https://git.openjdk.java.net/loom pull/103/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 103

View PR using the GUI difftool:
$ git pr show -t 103

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/loom/pull/103.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 16, 2022

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into fibers will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@stefank stefank force-pushed the loom_includes_braces_whitespaces branch from 0cedc53 to b342be7 Compare March 16, 2022 06:55
@openjdk
Copy link

openjdk bot commented Mar 16, 2022

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Fix includes, braces, and whitespaces

Reviewed-by: eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the fibers branch:

  • fb34338: fix Kitchensink failures related to interp_only_mode for unmounted virtual threads

Please see this link for an up-to-date comparison between the source branch of this pull request and the fibers branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@fisk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Ready to be integrated rfr Ready for review labels Mar 16, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 16, 2022

Webrevs

Copy link
Collaborator

@fisk fisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Ship it!

@stefank
Copy link
Member Author

stefank commented Mar 16, 2022

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Mar 16, 2022
@openjdk
Copy link

openjdk bot commented Mar 16, 2022

@stefank
Your change (at version b342be7) is now ready to be sponsored by a Committer.

@AlanBateman
Copy link
Collaborator

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 16, 2022

Going to push as commit 174cc90.
Since your change was applied there have been 4 commits pushed to the fibers branch:

  • 81750b3: Make clear the cases where invalid thread is returned
  • 187d7ae: Increase max expected duration to allow for loaded test machines
  • 0e8a896: Improve comment
  • fb34338: fix Kitchensink failures related to interp_only_mode for unmounted virtual threads

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 16, 2022
@openjdk openjdk bot closed this Mar 16, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Mar 16, 2022
@openjdk
Copy link

openjdk bot commented Mar 16, 2022

@AlanBateman @stefank Pushed as commit 174cc90.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants