Skip to content

Commit abfab9e

Browse files
committedJan 15, 2020
8237223: Shenandoah: important flags should not be ergonomic for concurrent class unloading
Reviewed-by: zgu
1 parent ec5869e commit abfab9e

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed
 

‎src/hotspot/share/gc/shenandoah/shenandoahNormalMode.cpp

+5-4
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,14 @@
3333
#include "logging/logTag.hpp"
3434

3535
void ShenandoahNormalMode::initialize_flags() const {
36-
SHENANDOAH_ERGO_ENABLE_FLAG(ExplicitGCInvokesConcurrent);
37-
SHENANDOAH_ERGO_ENABLE_FLAG(ShenandoahImplicitGCInvokesConcurrent);
3836
if (ShenandoahConcurrentRoots::can_do_concurrent_class_unloading()) {
39-
SHENANDOAH_ERGO_ENABLE_FLAG(ShenandoahSuspendibleWorkers);
40-
SHENANDOAH_ERGO_DISABLE_FLAG(VerifyBeforeExit);
37+
FLAG_SET_DEFAULT(ShenandoahSuspendibleWorkers, true);
38+
FLAG_SET_DEFAULT(VerifyBeforeExit, false);
4139
}
4240

41+
SHENANDOAH_ERGO_ENABLE_FLAG(ExplicitGCInvokesConcurrent);
42+
SHENANDOAH_ERGO_ENABLE_FLAG(ShenandoahImplicitGCInvokesConcurrent);
43+
4344
// Final configuration checks
4445
SHENANDOAH_CHECK_FLAG_SET(ShenandoahLoadRefBarrier);
4546
SHENANDOAH_CHECK_FLAG_SET(ShenandoahSATBBarrier);

0 commit comments

Comments
 (0)
Please sign in to comment.