Skip to content

Commit 62ff55d

Browse files
author
Jatin Bhateja
committedJul 9, 2021
8269952: compiler/vectorapi/VectorCastShape*Test.java tests failed on avx2 machines
Reviewed-by: kvn, dlong
1 parent 46c610c commit 62ff55d

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed
 

‎src/hotspot/cpu/x86/x86.ad

+5-5
Original file line numberDiff line numberDiff line change
@@ -6602,7 +6602,7 @@ instruct vcastBtoX(vec dst, vec src) %{
66026602
%}
66036603

66046604
instruct castStoX(vec dst, vec src, rRegP scratch) %{
6605-
predicate(UseAVX <= 2 &&
6605+
predicate((UseAVX <= 2 || !VM_Version::supports_avx512vlbw()) &&
66066606
vector_length(n->in(1)) <= 8 && // src
66076607
vector_element_basic_type(n) == T_BYTE);
66086608
effect(TEMP scratch);
@@ -6618,7 +6618,7 @@ instruct castStoX(vec dst, vec src, rRegP scratch) %{
66186618
%}
66196619

66206620
instruct vcastStoX(vec dst, vec src, vec vtmp, rRegP scratch) %{
6621-
predicate(UseAVX <= 2 &&
6621+
predicate((UseAVX <= 2 || !VM_Version::supports_avx512vlbw()) &&
66226622
vector_length(n->in(1)) == 16 && // src
66236623
vector_element_basic_type(n) == T_BYTE);
66246624
effect(TEMP dst, TEMP vtmp, TEMP scratch);
@@ -6636,7 +6636,7 @@ instruct vcastStoX(vec dst, vec src, vec vtmp, rRegP scratch) %{
66366636
%}
66376637

66386638
instruct vcastStoX_evex(vec dst, vec src) %{
6639-
predicate(UseAVX > 2 ||
6639+
predicate((UseAVX > 2 && VM_Version::supports_avx512vlbw()) ||
66406640
(vector_length_in_bytes(n) >= vector_length_in_bytes(n->in(1)))); // dst >= src
66416641
match(Set dst (VectorCastS2X src));
66426642
format %{ "vector_cast_s2x $dst,$src\t!" %}
@@ -6751,13 +6751,13 @@ instruct vcastItoX_evex(vec dst, vec src) %{
67516751
__ evpmovdw($dst$$XMMRegister, $src$$XMMRegister, src_vlen_enc);
67526752
break;
67536753
case T_FLOAT:
6754-
__ vcvtdq2ps($dst$$XMMRegister, $dst$$XMMRegister, dst_vlen_enc);
6754+
__ vcvtdq2ps($dst$$XMMRegister, $src$$XMMRegister, dst_vlen_enc);
67556755
break;
67566756
case T_LONG:
67576757
__ vpmovsxdq($dst$$XMMRegister, $src$$XMMRegister, dst_vlen_enc);
67586758
break;
67596759
case T_DOUBLE:
6760-
__ vcvtdq2pd($dst$$XMMRegister, $dst$$XMMRegister, dst_vlen_enc);
6760+
__ vcvtdq2pd($dst$$XMMRegister, $src$$XMMRegister, dst_vlen_enc);
67616761
break;
67626762
default:
67636763
ShouldNotReachHere();

‎test/hotspot/jtreg/ProblemList.txt

-2
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,6 @@ compiler/whitebox/MakeMethodNotCompilableTest.java 8265360 macosx-aarch64
7070

7171
compiler/codecache/jmx/PoolsIndependenceTest.java 8264632 macosx-x64
7272

73-
compiler/vectorapi/VectorCastShape128Test.java 8269952 generic-x64
74-
compiler/vectorapi/VectorCastShape64Test.java 8269952 generic-x64
7573

7674
#############################################################################
7775

0 commit comments

Comments
 (0)
Please sign in to comment.