Skip to content
This repository was archived by the owner on Aug 27, 2022. It is now read-only.
/ lanai Public archive

8261632: Cached text AA rendering crashes with Metal API validation #185

Closed
wants to merge 1 commit into from
+1 −1
Closed

8261632: Cached text AA rendering crashes with Metal API validation #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLVertexCache.h
View file
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@
/**
* Constants that control the size of the vertex cache.
*/
#define MTLVC_MAX_INDEX 1536
#define MTLVC_MAX_INDEX 250
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful to add a comment about why the max index is 250. Do you think it is worth filing a follow-up issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kevin,

J2DVertex size is 16 bytes and since setVertexBytes has a limit of 4KB we can have maximum of 250 J2DVertex elements. I have created https://bugs.openjdk.java.net/browse/JDK-8261650 to add the comment.

Thanks,
Jay


/**
* Constants that control the size of the texture tile cache used for