8242004: TextLayout throws Exception with a non-invertible transform

Reviewed-by: serb, jdv

Author: prrace

src/java.desktop/share/classes/sun/font/GlyphLayout.java

@@ -213,7 +213,6 @@ private static final class SDCache {
         public FontRenderContext key_frc;
 
         public AffineTransform dtx;
-        public AffineTransform invdtx;
         public AffineTransform gtx;
         public Point2D.Float delta;
         public FontStrikeDesc sd;
@@ -229,14 +228,6 @@ private SDCache(Font font, FontRenderContext frc) {
             dtx.setTransform(dtx.getScaleX(), dtx.getShearY(),
                              dtx.getShearX(), dtx.getScaleY(),
                              0, 0);
-            if (!dtx.isIdentity()) {
-                try {
-                    invdtx = dtx.createInverse();
-                }
-                catch (NoninvertibleTransformException e) {
-                    throw new InternalError(e);
-                }
-            }
 
             float ptSize = font.getSize2D();
             if (font.isTransformed()) {
@@ -480,10 +471,6 @@ public StandardGlyphVector layout(Font font, FontRenderContext frc,
             }
         }
 
-        //        if (txinfo.invdtx != null) {
-        //            _gvdata.adjustPositions(txinfo.invdtx);
-        //        }
-
         // If layout fails (negative glyph count) create an un-laid out GV instead.
         // ie default positions. This will be a lot better than the alternative of
         // a complete blank layout.
@@ -579,10 +566,6 @@ public void grow(int delta) {
             _indices = nindices;
         }
 
-        public void adjustPositions(AffineTransform invdtx) {
-            invdtx.transform(_positions, 0, _positions, 0, _count);
-        }
-
         public StandardGlyphVector createGlyphVector(Font font, FontRenderContext frc, StandardGlyphVector result) {
 
             // !!! default initialization until we let layout engines do it

src/java.desktop/share/classes/sun/font/StandardGlyphVector.java

@@ -876,29 +876,6 @@ public float[] getGlyphInfo() {
         return result;
     }
 
-    /**
-     * !!! not used currently, but might be by getPixelbounds?
-     */
-    public void pixellate(FontRenderContext renderFRC, Point2D loc, Point pxResult) {
-        if (renderFRC == null) {
-            renderFRC = frc;
-        }
-
-        // it is a total pain that you have to copy the transform.
-
-        AffineTransform at = renderFRC.getTransform();
-        at.transform(loc, loc);
-        pxResult.x = (int)loc.getX(); // but must not behave oddly around zero
-        pxResult.y = (int)loc.getY();
-        loc.setLocation(pxResult.x, pxResult.y);
-        try {
-            at.inverseTransform(loc, loc);
-        }
-        catch (NoninvertibleTransformException e) {
-            throw new IllegalArgumentException("must be able to invert frc transform");
-        }
-    }
-
     //////////////////////
     // StandardGlyphVector package private methods
     /////////////////////

src/java.desktop/share/classes/sun/java2d/SunGraphics2D.java

@@ -667,6 +667,9 @@ public FontInfo checkFontInfo(FontInfo info, Font font,
             }
         }
 
+        info.nonInvertibleTx =
+            (Math.abs(textAt.getDeterminant()) <= Double.MIN_VALUE);
+
         info.font2D = FontUtilities.getFont2D(font);
 
         int fmhint = fractionalMetricsHint;

src/java.desktop/share/classes/sun/java2d/loops/FontInfo.java

@@ -47,6 +47,7 @@ public class FontInfo implements Cloneable {
     public FontStrike fontStrike;
     public double[] devTx;
     public double[] glyphTx;
+    public boolean nonInvertibleTx;
     public int pixelHeight;
     public float originX;
     public float originY;

src/java.desktop/share/classes/sun/java2d/pipe/GlyphListPipe.java

@@ -44,6 +44,9 @@ public void drawString(SunGraphics2D sg2d, String s,
                            double x, double y)
     {
         FontInfo info = sg2d.getFontInfo();
+        if (info.nonInvertibleTx) {
+            return;
+        }
         if (info.pixelHeight > OutlineTextRenderer.THRESHHOLD) {
             SurfaceData.outlineTextRenderer.drawString(sg2d, s, x, y);
             return;
@@ -80,6 +83,9 @@ public void drawChars(SunGraphics2D sg2d,
                           int ix, int iy)
     {
         FontInfo info = sg2d.getFontInfo();
+        if (info.nonInvertibleTx) {
+            return;
+        }
         float x, y;
         if (info.pixelHeight > OutlineTextRenderer.THRESHHOLD) {
             SurfaceData.outlineTextRenderer.drawChars(
@@ -114,6 +120,9 @@ public void drawGlyphVector(SunGraphics2D sg2d, GlyphVector gv,
     {
         FontRenderContext frc = gv.getFontRenderContext();
         FontInfo info = sg2d.getGVFontInfo(gv.getFont(), frc);
+        if (info.nonInvertibleTx) {
+            return;
+        }
         if (info.pixelHeight > OutlineTextRenderer.THRESHHOLD) {
             SurfaceData.outlineTextRenderer.drawGlyphVector(sg2d, gv, x, y);
             return;

test/jdk/java/awt/FontClass/NonInvertibleTransformTextTest.java

@@ -0,0 +1,74 @@
+/*
+ * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug 8242004
+ * @summary Font/Text APIs should handle a non-invertible transform.
+ */
+
+import java.awt.Color;
+import java.awt.Font;
+import java.awt.Graphics2D;
+import java.awt.font.FontRenderContext;
+import java.awt.font.GlyphVector;
+import java.awt.font.TextLayout;
+import java.awt.geom.AffineTransform;
+import java.awt.image.BufferedImage;
+
+public class NonInvertibleTransformTextTest {
+
+    public static void main(String[] args) {
+
+        // Create a non-invertible transform
+        AffineTransform at = new AffineTransform(1f, 0.0f, -15, 0.0, -1, -30);
+
+        // Test creating a text layout
+        FontRenderContext frc = new FontRenderContext(at, false, false);
+        Font font = new Font(Font.DIALOG, Font.PLAIN, 12);
+        TextLayout tl = new TextLayout("ABC", font, frc);
+        tl.getOutline(new AffineTransform());
+
+        // Test rendering text
+        BufferedImage bi = new BufferedImage(100, 100,
+                                             BufferedImage.TYPE_INT_RGB);
+        Graphics2D g2d = bi.createGraphics();
+        g2d.setColor(Color.white);
+        g2d.fillRect(0,0,100,100);
+        g2d.setColor(Color.red);
+        tl.draw(g2d, 50, 50); // first the TextLayout created above
+
+        // Now a laid out GlyphVector
+        Font f = g2d.getFont();
+        char[] chs = { 'A', 'B', 'C' };
+        GlyphVector gv = f.layoutGlyphVector(frc, chs, 0, chs.length, 0);
+        g2d.drawGlyphVector(gv, 20, 20);
+
+        // Now under the transform, the basic text drawing calls.
+        g2d.setTransform(at);
+        g2d.drawString("ABC", 20, 20);
+        g2d.drawChars(chs, 0, chs.length, 20, 20);
+        // And TextLayout again.
+        tl.draw(g2d, 50, 50);
+    }
+}