Skip to content
This repository was archived by the owner on Aug 27, 2022. It is now read-only.
/ lanai Public archive

Commit 8f26a1f

Browse files
author
Alexey Semenyuk
committedJul 9, 2020
8247229: jpackage tests failed due to "semop(1): encountered an error: Invalid argument"
Reviewed-by: herrick, almatvee
1 parent 37880ba commit 8f26a1f

File tree

2 files changed

+98
-1
lines changed

2 files changed

+98
-1
lines changed
 

‎src/jdk.incubator.jpackage/linux/classes/jdk/incubator/jpackage/internal/LinuxDebBundler.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,9 @@ private File buildDeb(Map<String, ? super Object> params,
464464
outFile.getAbsolutePath()));
465465

466466
// run dpkg
467-
Executor.of(cmdline.toArray(String[]::new)).executeExpectSuccess();
467+
RetryExecutor.retryOnKnownErrorMessage(
468+
"semop(1): encountered an error: Invalid argument").execute(
469+
cmdline.toArray(String[]::new));
468470

469471
Log.verbose(MessageFormat.format(I18N.getString(
470472
"message.output-to-location"), outFile.getAbsolutePath()));
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
1+
/*
2+
* Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.
3+
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4+
*
5+
* This code is free software; you can redistribute it and/or modify it
6+
* under the terms of the GNU General Public License version 2 only, as
7+
* published by the Free Software Foundation. Oracle designates this
8+
* particular file as subject to the "Classpath" exception as provided
9+
* by Oracle in the LICENSE file that accompanied this code.
10+
*
11+
* This code is distributed in the hope that it will be useful, but WITHOUT
12+
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
13+
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
14+
* version 2 for more details (a copy is included in the LICENSE file that
15+
* accompanied this code).
16+
*
17+
* You should have received a copy of the GNU General Public License version
18+
* 2 along with this work; if not, write to the Free Software Foundation,
19+
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
20+
*
21+
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
22+
* or visit www.oracle.com if you need additional information or have any
23+
* questions.
24+
*/
25+
package jdk.incubator.jpackage.internal;
26+
27+
import java.io.IOException;
28+
import java.util.function.Consumer;
29+
30+
public final class RetryExecutor {
31+
RetryExecutor() {
32+
setMaxAttemptsCount(5);
33+
setAttemptTimeoutMillis(2 * 1000);
34+
}
35+
36+
RetryExecutor setMaxAttemptsCount(int v) {
37+
attempts = v;
38+
return this;
39+
}
40+
41+
RetryExecutor setAttemptTimeoutMillis(int v) {
42+
timeoutMillis = v;
43+
return this;
44+
}
45+
46+
RetryExecutor setExecutorInitializer(Consumer<Executor> v) {
47+
executorInitializer = v;
48+
return this;
49+
}
50+
51+
void abort() {
52+
aborted = true;
53+
}
54+
55+
static RetryExecutor retryOnKnownErrorMessage(String v) {
56+
RetryExecutor result = new RetryExecutor();
57+
return result.setExecutorInitializer(exec -> {
58+
exec.setOutputConsumer(output -> {
59+
if (!output.anyMatch(v::equals)) {
60+
result.abort();
61+
}
62+
});
63+
});
64+
}
65+
66+
void execute(String cmdline[]) throws IOException {
67+
aborted = false;
68+
for (;;) {
69+
try {
70+
Executor exec = Executor.of(cmdline);
71+
if (executorInitializer != null) {
72+
executorInitializer.accept(exec);
73+
}
74+
exec.executeExpectSuccess();
75+
break;
76+
} catch (IOException ex) {
77+
if (aborted || (--attempts) <= 0) {
78+
throw ex;
79+
}
80+
}
81+
82+
try {
83+
Thread.sleep(timeoutMillis);
84+
} catch (InterruptedException ex) {
85+
Log.verbose(ex);
86+
throw new RuntimeException(ex);
87+
}
88+
}
89+
}
90+
91+
private Consumer<Executor> executorInitializer;
92+
private boolean aborted;
93+
private int attempts;
94+
private int timeoutMillis;
95+
}

0 commit comments

Comments
 (0)
This repository has been archived.