Skip to content

7902766: Idempotent builds #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jonathan-gibbons
Copy link
Collaborator

@jonathan-gibbons jonathan-gibbons commented Sep 16, 2020

7902766: Idempotent builds
In aid of idempotent builds ...

Replace <delete> before <javac> with <depend>
Remove <delete> before copying help files

For now the tasks are just commented out. If you agree, they can be removed.


Progress

  • Change must not contain extraneous whitespace

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jtharness pull/6/head:pull/6
$ git checkout pull/6

Sorry, something went wrong.

Merge remote-tracking branch 'upstream/master' into idempotent-builds
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 16, 2020

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@jonathan-gibbons This change now passes all automated pre-integration checks

After integration, the commit message will be:

7902766: Idempotent builds

Reviewed-by: dbessono
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate c81dfc7333eea25f2a238551e63f7f8e4aa592f1.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 16, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@dbessono Only the author (@jonathan-gibbons) is allowed to issue the /issue command.

@dbessono
Copy link
Collaborator

/issue add CODETOOLS-7902766

@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@dbessono Only the author (@jonathan-gibbons) is allowed to issue the /issue command.

@dbessono dbessono changed the title Idempotent builds 7902766: Idempotent builds Sep 16, 2020
Copy link
Collaborator

@dbessono dbessono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for improving this aspect of the JTH build procedure!

@jonathan-gibbons
Copy link
Collaborator Author

/issue CODETOOLS-7902766

@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@jonathan-gibbons This issue is referenced in the PR title - it will now be updated.

@jonathan-gibbons
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot closed this Sep 16, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2020
@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@jonathan-gibbons Pushed as commit 332abaf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants