7902698: Collision of zero timestamp as a special value with use in filesystems

[cushon]

This fixes a bug when the timestamp of a test file is set to zero, since jtharness currently uses zero as a special value. See discussion in CODETOOLS-7902698.

---

Progress

• Change must not contain extraneous whitespace

Issue

• CODETOOLS-7902698: Collision of zero timestamp as a special value with use in filesystems

Reviewers

• Dmitry Bessonov (@dbessono - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jtharness pull/22/head:pull/22
$ git checkout pull/22

Update a local copy of the PR:
$ git checkout pull/22
$ git pull https://git.openjdk.java.net/jtharness pull/22/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22

View PR using the GUI difftool:
$ git pr show -t 22

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jtharness/pull/22.diff

[bridgekeeper]

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cushon This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7902698: Collision of zero timestamp as a special value with use in filesystems

Reviewed-by: dbessono

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 586965e: 7903079: Feature Tests - Adding six JavaTest GUI legacy automated test scripts
• 3d72bd1: 7903076: Feature Tests - Adding five JavaTest GUI legacy automated feature test scripts

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dbessono) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 02: Full - Incremental (d6fef84d)
• 01: Full - Incremental (c988435a)
• 00: Full (b56f7172)

[dbessono]

It seems that previously zero default value served as "undefined yet" for these fields, now switched to "-1" as their default value. However 'URLConnection::getLastModified' returns "0 if not known" and 'File::lastModified' spec asserts: "returns 0L if the file does not exist or if an I/O error occurs. The value may be negative indicating the number of milliseconds before the epoch".

It possibly would be more reliable and readable to switch types of these fields from 'long' to OptionalLong with OptionalLong.empty() as their default value.

[cushon]

Thanks for the review!

It possibly would be more reliable and readable to switch types of these fields from 'long' to OptionalLong with OptionalLong.empty() as their default value.

Done

[dbessono]

Likely the same thing here, the mentioned SelectionTest passes with

            if (lastScanDate.isPresent() && thisScanDate <= lastScanDate.getAsLong() ) {
                return false;
            }

[cushon]

Done

[dbessono]

seeing a failure of com.sun.javatest.SelectionTest regression test... inlined comments on the possible changes

[cushon]

/integrate

[openjdk]

@cushon
Your change (at version d6fef84) is now ready to be sponsored by a Committer.

[dbessono]

/sponsor

[openjdk]

Going to push as commit 6e1a709.
Since your change was applied there have been 2 commits pushed to the master branch:

• 586965e: 7903079: Feature Tests - Adding six JavaTest GUI legacy automated test scripts
• 3d72bd1: 7903076: Feature Tests - Adding five JavaTest GUI legacy automated feature test scripts

Your commit was automatically rebased without conflicts.

[openjdk]

@dbessono @cushon Pushed as commit 6e1a709.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.