7902649: Allow a testsuite to define several TestFilters specific for this suite

[dbessono]

Currently TestSuite class has a method to override that returns only one test filter:

TestFilter createTestFilter(TestEnvironment)

There are situations when test suite has several test filters that it is forced however to hide behind an umbrella filter. It is more natural and convenient to let test suite return a collection of atomized filters that would be iterated on the JTHarness side and listed in the test run stats separately and informatively.

---

Progress

• Change must not contain extraneous whitespace

Issue

• CODETOOLS-7902649: Allow testsuite to define several TestFilters specific for this suite

Download

$ git fetch https://git.openjdk.java.net/jtharness pull/2/head:pull/2
$ git checkout pull/2

[bridgekeeper]

👋 Welcome back dbessono! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[openjdk]

@dbessono This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

7902649: Allow a testsuite to define several TestFilters specific for this suite

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 33 commits pushed to the master branch:

• 1cdb603: 7902670: (spotbugs) TestTreeModel - No relationship between generic parameter and method argument
• d47e258: (preview/tck.test) added more regression tests
• 52d4fba: 7902669: (spotbugs) EditLinks - No relationship between generic parameter and method argument
• 4aedeea: (preview/tck.test) added more regression tests
• 4628187: 7902668: (spotbugs) TestTreePanel - Suspicious comparison of Integer references
• 3f2146b: (spotbugs) extra fix for "instanceof will always return 'false'" - avoiding NPE
• 7cd1e82: (spotbugs) extra fix for - "instanceof will always return 'false' - FileQuestion (com.sun.interview)" - avoiding NPE
• 6d05059: 7902667: (spotbugs) instanceof will always return 'false' - FileQuestion (com.sun.interview)
• 81753cf: 7902666: (spotbugs) Infinite recursive loop in (com.sun.javatest.exec.TestTreeModel.invalidateNodeInfo(TestResultTable$TreeNode))
• 940b5b1: 7902665: (spotbugs) Infinite recursive loop in com.sun.javatest.exec.ExecToolManager.showError(String, Object)
• ... and 23 more: https://git.openjdk.java.net/jtharness/compare/368c807f6abf1998900586d2d055c7b48c637d7f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 1cdb6037ae0ea9aa38c559859ef84529172281ac.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (3a389bc)
• 00: Full (2cbc74a)

[dbessono]

Most complex changes are in ET_FilterHandler.java

[dbessono]

After some conversations it is considered that a safer, less disturbing, more balanced, and actually simpler-to-implement approach might be - just to allow TestSuite to return a composite test filter that would be decomposed on the JTH side into several first class test filters.