Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6710: Add rule to detect if an old version of Lucene is in use #89

Closed
wants to merge 2 commits into from

Conversation

Gunde
Copy link
Collaborator

@Gunde Gunde commented Jun 26, 2020

JMC has a few hard coded checks to exclude LookaheadSuccess Error instances, we should instead point out to users if they're using an older version of Lucene (or Solr/ElasticSearch) before they started re-using the same Error instance.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6710: Add rule to detect if an old version of Lucene is in use

Reviewers

  • Marcus Hirt (hirt - Reviewer) ⚠️ Review applies to e211880

Download

$ git fetch https://git.openjdk.java.net/jmc pull/89/head:pull/89
$ git checkout pull/89

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 26, 2020

👋 Welcome back hdafgard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jun 26, 2020
Copy link
Member

@thegreystone thegreystone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@openjdk
Copy link

openjdk bot commented Jun 26, 2020

@Gunde This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6710: Add rule to detect if an old version of Lucene is in use

Reviewed-by: hirt
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 0a1c4b38617cb77d16da33f2f0798926db23d7e9.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 26, 2020
@mlbridge
Copy link

mlbridge bot commented Jun 26, 2020

Webrevs

@Gunde
Copy link
Collaborator Author

Gunde commented Jun 26, 2020

/integrate

@openjdk openjdk bot closed this Jun 26, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 26, 2020
@openjdk
Copy link

openjdk bot commented Jun 26, 2020

@Gunde
Pushed as commit 28b1657.

@Gunde Gunde deleted the lucene-rule branch June 26, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants