Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6702: Sanitize more data #58

Closed
wants to merge 6 commits into from
Closed

Conversation

Gunde
Copy link
Collaborator

@Gunde Gunde commented Feb 21, 2020

Sanitizing some data that wasn't sanitizes previously.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • Marcus Hirt (hirt - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jmc pull/58/head:pull/58
$ git checkout pull/58

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2020

👋 Welcome back hdafgard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Feb 21, 2020
@Gunde Gunde requested a review from thegreystone February 21, 2020 17:19
@openjdk
Copy link

openjdk bot commented Feb 21, 2020

@Gunde This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6702: Sanitize more data

Reviewed-by: hirt
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 9c2076cee7631b1de71173f2febf4b1343ff9085.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 21, 2020
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2020

Webrevs

@Gunde Gunde requested a review from thegreystone February 21, 2020 18:14
@Gunde
Copy link
Collaborator Author

Gunde commented Feb 21, 2020

/integrate

@openjdk openjdk bot closed this Feb 21, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 21, 2020
@openjdk
Copy link

openjdk bot commented Feb 21, 2020

@Gunde
Pushed as commit 9c2076c.

@mlbridge
Copy link

mlbridge bot commented Feb 21, 2020

Mailing list message from Henrik Dafgård on jmc-dev:

Changeset: 9c2076c
Author: Henrik Dafg?rd <hdafgard at openjdk.org>
Date: 2020-02-21 18:30:32 +0000
URL: https://git.openjdk.java.net/jmc/commit/9c2076ce

6702: Sanitize more data

Reviewed-by: hirt

! core/org.openjdk.jmc.common/META-INF/MANIFEST.MF
! core/org.openjdk.jmc.common/pom.xml
! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/FormatToolkit.java
! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/ClassLeakingRule.java
! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/DumpReasonRule.java
! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/FlightRecordingSupportRule.java
! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/BiasedLockingRevocationRule.java
! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/JavaBlockingRule.java
! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/MethodProfilingRule.java
! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/VMOperationRule.java
! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/AutoBoxingRule.java
! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml

@Gunde Gunde deleted the encode-rule-results branch February 21, 2020 19:24
@ret2libc
Copy link

ret2libc commented Apr 2, 2020

@Gunde Hi, does this need a CVE since it seems there were possible XSS? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants