Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6686: Adding FAQ to wiki/readme #48

Closed
wants to merge 1 commit into from

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Feb 10, 2020

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JMC-6686: Add a JMC FAQ to the JMC Wiki...

Approvers

  • Jie Kang (jkang - Author)
  • Henrik Dafgård (hdafgard - Reviewer)

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 10, 2020

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Feb 10, 2020
@mlbridge
Copy link

mlbridge bot commented Feb 10, 2020

Webrevs

@mlbridge
Copy link

mlbridge bot commented Feb 10, 2020

Mailing list message from Mario Torre on jmc-dev:

On Mon, 2020-02-10 at 12:35 +0000, Marcus Hirt wrote:

6686: Adding FAQ to wiki/readme

-------------

Commits:
- 9d9bf24: 6686: Adding FAQ to wiki/readme

Changes: https://git.openjdk.java.net/jmc/pull/48/files
Webrev: https://webrevs.openjdk.java.net/jmc/48/webrev.00
Issue: https://bugs.openjdk.java.net/browse/JMC-6686
Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod
Patch: https://git.openjdk.java.net/jmc/pull/48.diff
Fetch: git fetch https://git.openjdk.java.net/jmc
pull/48/head:pull/48

PR: https://git.openjdk.java.net/jmc/pull/48

Looks good to me.

Cheers,
Mario
--
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898

Copy link
Collaborator

@jiekang jiekang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Feb 10, 2020

@thegreystone This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6686: Adding FAQ to wiki/readme

Reviewed-by: jkang, hdafgard
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate c85d31b0f89dab2aecf80913313a8fa37ddbe09f.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 10, 2020
@thegreystone
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Feb 10, 2020
@openjdk openjdk bot added integrated and removed ready labels Feb 10, 2020
@openjdk
Copy link

openjdk bot commented Feb 10, 2020

@thegreystone The following commits have been pushed to master since your change was applied:

  • c85d31b: 6685: Parse more fields directly to primitive values

Your commit was automatically rebased without conflicts.

Pushed as commit 7485fad.

@openjdk openjdk bot removed the rfr label Feb 10, 2020
@mlbridge
Copy link

mlbridge bot commented Feb 10, 2020

Mailing list message from Marcus Hirt on jmc-dev:

Changeset: 7485fad
Author: Marcus Hirt <hirt at openjdk.org>
Date: 2020-02-10 19:19:31 +0000
URL: https://git.openjdk.java.net/jmc/commit/7485fad6

6686: Adding FAQ to wiki/readme

Reviewed-by: jkang, hdafgard

! README.md

@thegreystone thegreystone deleted the faq branch May 18, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants