Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7447: Add serializers and writer modules to core test coverage #335

Closed
wants to merge 1 commit into from

Conversation

aptmac
Copy link
Member

@aptmac aptmac commented Nov 22, 2021

This PR addresses JMC-7447 [0], in which the core coverage reports are missing the serializers and writer modules. The changes here simply add the missing modules to the coverage dependency list.

Additionally, the jdp.test module is missing the <scope>test</scope> attribute, so I've added it in here.

[0] https://bugs.openjdk.java.net/browse/JMC-7447


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7447: Add serializers and writer modules to core test coverage

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/335/head:pull/335
$ git checkout pull/335

Update a local copy of the PR:
$ git checkout pull/335
$ git pull https://git.openjdk.java.net/jmc pull/335/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 335

View PR using the GUI difftool:
$ git pr show -t 335

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/335.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2021

👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 22, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2021

Webrevs

@thegreystone thegreystone changed the title 7447: add serializers and writer modules to core test coverage 7447: Add serializers and writer modules to core test coverage Nov 25, 2021
@openjdk
Copy link

openjdk bot commented Nov 25, 2021

@aptmac This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7447: Add serializers and writer modules to core test coverage

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 24f4cb0: 5904: Merge org.openjdk.jmc.ui.celleditors with org.openjdk.jmc.rjmx.ui.celleditors
  • d218205: 7440: JMC fails on Apple M1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 25, 2021
@aptmac
Copy link
Member Author

aptmac commented Nov 25, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Nov 25, 2021

Going to push as commit 3ce6483.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 35c8e0e: 7446: Add Maven profile for enabling test coverage
  • 24f4cb0: 5904: Merge org.openjdk.jmc.ui.celleditors with org.openjdk.jmc.rjmx.ui.celleditors
  • d218205: 7440: JMC fails on Apple M1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 25, 2021
@openjdk
Copy link

openjdk bot commented Nov 25, 2021

@aptmac Pushed as commit 3ce6483.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aptmac aptmac deleted the add-missing-coverage-core branch December 6, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants